`ssh_wrap` doesn't properly escape remote commands

[keysmashes]

When you run a command like ssh user@host COMMAND..., SSH doesn't do any particular escaping of COMMAND (https://unix.stackexchange.com/q/397400/226269). If you run echo foo \> bar, you will see the output foo > bar, but if you run ssh user@host echo foo \> bar, you'll end up writing foo to a file called bar on the remote.

This affects configurations which use the submit_host setting: if an argument contains a character with special meaning like >, e.g. in an LSF resource request like -Rselect[mem>4000], the argument will get mangled and the job won't be submitted properly.

As a workaround, you can .shellescape everything you use as a native argument in submit.yml.erb, but that means the app will no longer work properly in configurations that aren't using submit_host.

[johrstrom]

Thanks for the issue. Yes I think we should likely shellescape everywhere.

but that means the app will no longer work properly in configurations that aren't using submit_host.

I may not be imaginative enough to know what you mean here. It seems to me that escaping wouldn't break current behavior. Most likely because currently most centers don't have anything to escape, but I could be wrong.

[keysmashes]

It seems to me that escaping wouldn't break current behavior.

To get things working right now, with job submission via SSH (LSF submit_host), we have to manually shellescape a bunch of native arguments – if we then switch away from using SSH and have bsub invoked locally (or if OOD starts doing the escaping for us), we'll end up with excess escaping and it won't work properly.