Fix implicit image naming and tagging for vc-nimbus #209
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The image created during the build is generated without an explicit tag. This causes a
docker compose up -d, after a version bump, to not update the nimbus container out of the box. Instead you need to stop and remove manually and then remove the actual image from the local registry.Solution
Add an explicit image name and use the current nimbus version tag for the created image.
Downside
The default version needs to be set on two lines. The better approach would be to fully rely on the
.envfile and only maintain version there. However, this deviates from all other provided compose.