feat(cli): support subscription id (#15300)

* feat(cli): support subscription id

* fix: coverage

Author: tecton

packages/cli/src/commands/models/provision.ts

@@ -1,12 +1,27 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-import { CLICommand, CLIContext, InputsWithProjectPath } from "@microsoft/teamsfx-api";
+import {
+  CLICommand,
+  CLICommandOption,
+  CLIContext,
+  InputsWithProjectPath,
+} from "@microsoft/teamsfx-api";
 import { QuestionNames, newResourceGroupOption } from "@microsoft/teamsfx-core";
 import { getFxCore } from "../../activate";
 import { commands } from "../../resource";
 import { TelemetryEvent } from "../../telemetry/cliTelemetryEvents";
 import { EnvOption, IgnoreLoadEnvOption, ProjectFolderOption } from "../common";
 
+const subscriptionOption: CLICommandOption = {
+  name: "subscriptionId",
+  questionName: "targetSubscriptionId",
+  shortName: "sub",
+  description: "Azure Subscription ID.",
+  type: "string",
+  required: false,
+  default: "",
+};
+
 export const provisionCommand: CLICommand = {
   name: "provision",
   description: commands.provision.description,

packages/cli/src/userInteraction.ts

@@ -638,7 +638,7 @@ class CLIUserInteraction implements UserInteraction {
   }): Promise<Result<string, FxError>> {
     return new Promise<Result<string, FxError>>((resolve) => {
       const isWindows = process.platform === "win32";
-      const command = isWindows ? "cmd.exe" : "/bin/bash";
+      const command = args.shell ? args.shell : isWindows ? "cmd.exe" : "/bin/bash";
       const commandArgs = isWindows ? ["/c", args.cmd] : ["-c", args.cmd];
       logger.info(`Executing task: ${args.cmd}`);
       let output = "";

packages/cli/tests/unit/ui2.tests.ts

@@ -329,6 +329,22 @@ describe("runCommand", () => {
     assert.isTrue(spawnStub.calledOnce);
     assert.equal(spawnStub.firstCall.args[0], "cmd.exe");
   });
+  it("uses custom shell", async () => {
+    const mockChildProcess = {
+      on: sandbox.stub().callsFake((event, callback) => {
+        if (event === "close") {
+          callback(0);
+        }
+      }),
+    };
+    sandbox.stub(process, "platform").value("win32");
+    sandbox.stub(logger, "info").returns();
+    const spawnStub = sandbox.stub(child_process, "spawn").returns(mockChildProcess as any);
+    const res = await UI.runCommand({ cmd: "echo hello", shell: "powershell.exe" });
+    assert.isTrue(res.isOk());
+    assert.isTrue(spawnStub.calledOnce);
+    assert.equal(spawnStub.firstCall.args[0], "powershell.exe");
+  });
   it("error linux", async () => {
     const mockChildProcess = {
       on: sandbox.stub().callsFake((event, callback) => {