fix: remove type module property (#1125)

Author: fadi-george

example/IonicAngular/package.json

@@ -4,8 +4,8 @@
   "author": "Ionic Framework",
   "homepage": "https://ionicframework.com/",
   "scripts": {
-    "ng": "ng",
     "ionic:build": "../scripts/build.sh IonicAngular",
+    "ng": "ng",
     "start": "ng serve",
     "build": "ng build",
     "watch": "ng build --watch --configuration development",

example/IonicAngular/src/app/app.component.ts

@@ -16,6 +16,25 @@ export class AppComponent {
     const APP_ID = '77e32082-ea27-42e3-a898-c72e141824ef'; // Use your app ID
     OneSignal.Debug.setLogLevel(LogLevel.Verbose);
     OneSignal.initialize(APP_ID);
-    OneSignal.login('ionic-angular-8');
+
+    OneSignal.InAppMessages.addEventListener('click', (event) => {
+      console.log('OneSignal IAM clicked:', event);
+    });
+
+    OneSignal.InAppMessages.addEventListener('willDisplay', (event) => {
+      console.log('OneSignal: will display IAM: ', event);
+    });
+
+    OneSignal.InAppMessages.addEventListener('didDisplay', (event) => {
+      console.log('OneSignal: did display IAM: ', event);
+    });
+
+    OneSignal.InAppMessages.addEventListener('willDismiss', (event) => {
+      console.log('OneSignal: will dismiss IAM: ', event);
+    });
+
+    OneSignal.InAppMessages.addEventListener('didDismiss', (event) => {
+      console.log('OneSignal: did dismiss IAM: ', event);
+    });
   }
 }

example/IonicAngular/src/app/home/home.page.html

@@ -17,5 +17,17 @@ <h2>Welcome to OneSignal Ionic Angular Example</h2>
       This example demonstrates the OneSignal Cordova SDK integration with Ionic
       Angular.
     </p>
+
+    <ion-item>
+      <ion-input
+        label="External ID"
+        labelPlacement="floating"
+        placeholder="Enter external user ID"
+        [(ngModel)]="externalId"
+      ></ion-input>
+    </ion-item>
+    <ion-button expand="block" (click)="login()" [disabled]="!externalId">
+      Login
+    </ion-button>
   </div>
 </ion-content>

example/IonicAngular/src/app/home/home.page.ts

@@ -1,4 +1,5 @@
 import { Component } from '@angular/core';
+import OneSignal from 'onesignal-cordova-plugin';
 
 @Component({
   selector: 'app-home',
@@ -7,5 +8,14 @@ import { Component } from '@angular/core';
   standalone: false,
 })
 export class HomePage {
+  externalId = '';
+
   constructor() {}
+
+  login() {
+    if (this.externalId) {
+      OneSignal.login(this.externalId);
+      console.log('OneSignal login called with:', this.externalId);
+    }
+  }
 }

example/IonicCapOneSignal/android/app/capacitor.build.gradle

@@ -13,7 +13,7 @@ dependencies {
     implementation "com.onesignal:OneSignal:5.1.38"
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10"
 }
-apply from: "../../../../build-extras-onesignal.gradle"
+apply from: "../../node_modules/onesignal-cordova-plugin/build-extras-onesignal.gradle"
 
 if (hasProperty('postBuildExtras')) {
   postBuildExtras()

example/IonicCapOneSignal/vite.config.ts

@@ -4,12 +4,4 @@ import { defineConfig } from 'vite';
 // https://vitejs.dev/config/
 export default defineConfig({
   plugins: [react()],
-  optimizeDeps: {
-    include: ['dist'],
-  },
-  build: {
-    commonjsOptions: {
-      include: [/dist/, /node_modules/],
-    },
-  },
 });

example/scripts/build.sh

@@ -1,12 +1,14 @@
 #!/bin/bash
+# Get example name from argument or environment variable
+EXAMPLE_NAME="${1:-${EXAMPLE}}"
+
+echo "Preparing example: ${EXAMPLE_NAME}"
+
 # Get the directory where this script is located
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # Go to the root directory (two levels up from example/scripts/)
 cd "${SCRIPT_DIR}/../.."
 
-# Get example name from argument or environment variable
-EXAMPLE_NAME="${1:-${EXAMPLE}}"
-
 bun run build
 
 # Pack - remove old tarballs first to ensure fresh build
@@ -25,7 +27,11 @@ else
 fi
 
 # Build example
+echo "Building example: ${EXAMPLE_NAME}"
 if [ "$EXAMPLE_NAME" = "IonicAngular" ]; then
+  # Clear Angular cache to ensure fresh build
+  rm -rf .angular/cache
+
   ng build
 elif [ "$EXAMPLE_NAME" = "IonicCapOneSignal" ]; then
   tsc && vite build

package.json

@@ -12,7 +12,6 @@
     "type": "git",
     "url": "git+https://github.com/OneSignal/OneSignal-Cordova-SDK.git"
   },
-  "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {