Skip to content

Commit 5e8a8fe

Browse files
committed
moved test from ConsoleRenderTest to SchemaDiffTest class as suggested in review
1 parent 91ffc35 commit 5e8a8fe

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

core/src/test/java/org/openapitools/openapidiff/core/SchemaDiffTest.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,4 +438,21 @@ public void testAllOfDiff() {
438438
assertThat(changedSchema.getRequired().getMissing()).containsExactly("fieldA");
439439
assertThat(changedSchema.getRequired().getIncreased()).isEmpty();
440440
}
441+
442+
@Test
443+
void renderShowsNoDifferencesWhenCSVMediaTypeResponseExampleIsByteArray() {
444+
ChangedOpenApi changedOpenApi =
445+
OpenApiCompare.fromLocations(
446+
"issue-828-binary-example-for-csv-media-type.yaml",
447+
"issue-828-binary-example-for-csv-media-type.yaml");
448+
449+
assertThat(changedOpenApi).isNotNull();
450+
451+
assertThat(changedOpenApi.isUnchanged()).isTrue();
452+
assertThat(changedOpenApi.isDifferent()).isFalse();
453+
assertThat(changedOpenApi.isChanged()).isEqualTo(DiffResult.NO_CHANGES);
454+
assertThat(changedOpenApi.isIncompatible()).isFalse();
455+
assertThat(changedOpenApi.isCompatible()).isTrue();
456+
assertThat(changedOpenApi.isCoreChanged()).isEqualTo(DiffResult.NO_CHANGES);
457+
}
441458
}

core/src/test/java/org/openapitools/openapidiff/core/output/ConsoleRenderTest.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -76,19 +76,4 @@ public void renderShowsWhatsChangedSectionWithCorrectFormattingWhenEndpointIsCha
7676
.contains("What's Changed")
7777
.containsSubsequence("- GET /widgets", "Parameter:", "- Changed query-param-1 in query");
7878
}
79-
80-
@Test
81-
void renderShowsNoDifferencesWhenCSVMediaTypeResponseExampleIsByteArray() {
82-
ConsoleRender render = new ConsoleRender();
83-
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
84-
OutputStreamWriter outputStreamWriter = new OutputStreamWriter(outputStream);
85-
ChangedOpenApi diff =
86-
OpenApiCompare.fromLocations(
87-
"issue-828-binary-example-for-csv-media-type.yaml",
88-
"issue-828-binary-example-for-csv-media-type.yaml");
89-
render.render(diff, outputStreamWriter);
90-
assertThat(outputStream.toString()).isNotBlank();
91-
assertThat(outputStream.toString())
92-
.hasToString("No differences. Specifications are equivalent");
93-
}
9479
}

0 commit comments

Comments
 (0)