Skip to content

Commit 1879a1e

Browse files
authored
fix(#802): better error handling (#812)
* fix(#802): better error handling * fix(#802): show original error
1 parent 129c002 commit 1879a1e

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

apps/generator-cli/src/app/services/version-manager.service.ts

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class VersionManagerService {
9696
this.logger.log(
9797
chalk.red(`Unable to query repository, because of: "${e.message}". Return default versions instead.`)
9898
);
99-
this.printResponseError(e);
99+
//this.printResponseError(e);
100100
return this.getObservableVersions();
101101
})
102102
);
@@ -265,16 +265,21 @@ export class VersionManagerService {
265265
}
266266

267267
private printResponseError(error: AxiosError) {
268-
if (error.isAxiosError) {
269-
this.logger.log(chalk.red('\nResponse:'));
270-
Object.entries(error.response.headers).forEach((a) =>
271-
this.logger.log(...a)
272-
);
273-
this.logger.log();
274-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
275-
(error.response.data as any).on('data', (data) =>
276-
this.logger.log(data.toString('utf8'))
277-
);
268+
try {
269+
if (error.isAxiosError) {
270+
this.logger.log(chalk.red('\nResponse:'));
271+
Object.entries(error.response.headers).forEach((a) =>
272+
this.logger.log(...a)
273+
);
274+
this.logger.log();
275+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
276+
(error.response.data as any).on('data', (data) =>
277+
this.logger.log(data.toString('utf8'))
278+
);
279+
}
280+
} catch(e) {
281+
// simply show the original error if the above code block fails
282+
this.logger.log('Errors: ', error);
278283
}
279284
}
280285

0 commit comments

Comments
 (0)