Skip to content

Commit ef5d5da

Browse files
committed
code quality & restore comment
1 parent ea06f0c commit ef5d5da

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

library/EngineBlock/Saml2/AuthnRequestAnnotationDecorator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ class EngineBlock_Saml2_AuthnRequestAnnotationDecorator extends EngineBlock_Saml
6161
/**
6262
* @var string|null Temporary storage for serialized XML
6363
*/
64-
private ?string $_serializableSspMessageXml;
64+
private ?string $_serializableSspMessageXml = null;
6565

6666
/**
6767
* @var string|null Persisted RelayState while serialized (not part of the AuthnRequest XML itself)
6868
*/
69-
private ?string $_serializableRelayState;
69+
private ?string $_serializableRelayState = null;
7070

7171
/**
7272
* @param AuthnRequest $request

library/EngineBlock/Saml2/ResponseAnnotationDecorator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,12 @@ class EngineBlock_Saml2_ResponseAnnotationDecorator extends EngineBlock_Saml2_Me
8686
/**
8787
* @var string Temporary storage for serialized XML
8888
*/
89-
private ?string $_serializableSspMessageXml;
89+
private ?string $_serializableSspMessageXml = null;
9090

9191
/**
9292
* @var string|null Persisted RelayState while serialized (not part of the AuthnRequest XML itself)
9393
*/
94-
private ?string $_serializableRelayState;
94+
private ?string $_serializableRelayState = null;
9595

9696
/**
9797
* @param Response $response

src/OpenConext/EngineBlockBundle/Doctrine/DqlFunction/Md5.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ class Md5 extends FunctionNode
2929

3030
public function getSql(SqlWalker $sqlWalker): string
3131
{
32-
// Directly emit the MD5 SQL function instead of using the deprecated platform->getMd5Expression() helper.
3332
return 'MD5(' . $this->value->dispatch($sqlWalker) . ')';
3433
}
3534

src/OpenConext/EngineBlockBundle/Doctrine/Type/CollabPersonIdType.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform): mixed
6565
try {
6666
$entityId = new CollabPersonId($value);
6767
} catch (InvalidArgumentException $e) {
68+
// get nice standard message, so we can throw it keeping the exception chain
6869
$doctrineExceptionMessage = sprintf(
6970
'Could not convert database value "%s" to Doctrine Type %s. Expected format: %s',
7071
$value,

0 commit comments

Comments
 (0)