GamePlayerUtils: Refactor _bonusesToBeDisplayed

Author: bm01

GameServer/gameutils/GamePlayerUtils.cs

@@ -13,7 +13,46 @@ namespace DOL.GS
     /// </summary>
     public static class GamePlayerUtils
     {
-        private static readonly int[] _bonusesToBeDisplayed = [9, 10, 150, 151, 153, 154, 155, 173, 174, 179, 180, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 210, 247, 248, 251, 252, 253, 254];
+        private static readonly HashSet<eProperty> _bonusesToBeDisplayed =
+        [
+            eProperty.MaxMana,
+            eProperty.MaxHealth,
+            eProperty.HealthRegenerationAmount,
+            eProperty.PowerRegenerationAmount,
+            eProperty.SpellRange,
+            eProperty.ArcheryRange,
+            eProperty.MeleeSpeed,
+            eProperty.MeleeDamage,
+            eProperty.RangedDamage,
+            eProperty.BladeturnReinforcement,
+            eProperty.DefensiveBonus,
+            eProperty.NegativeReduction,
+            eProperty.PieceAblative,
+            eProperty.ReactionaryStyleDamage,
+            eProperty.SpellPowerCost,
+            eProperty.StyleCostReduction,
+            eProperty.ToHitBonus,
+            eProperty.ArcherySpeed,
+            eProperty.ArrowRecovery,
+            eProperty.BuffEffectiveness,
+            eProperty.CastingSpeed,
+            eProperty.OffhandDamageAndChance,
+            eProperty.DebuffEffectiveness,
+            eProperty.Fatigue,
+            eProperty.HealingEffectiveness,
+            eProperty.PowerPool,
+            eProperty.ResistPierce,
+            eProperty.SpellDamage,
+            eProperty.SpellDuration,
+            eProperty.StyleDamage,
+            eProperty.MaxHealthCapBonus,
+            eProperty.BountyPoints,
+            eProperty.XpPoints,
+            eProperty.Conversion,
+            eProperty.StyleAbsorb,
+            eProperty.RealmPoints,
+            eProperty.ArcaneSyphon
+        ];
 
         #region Spot and Area Description / Translation
         /// <summary>
@@ -265,7 +304,7 @@ Outpost Bonuses
 
             foreach (eProperty property in Enum.GetValues<eProperty>())
             {
-                if (player.ItemBonus[property] <= 0 || Array.BinarySearch(_bonusesToBeDisplayed, (int) property) < 0)
+                if (player.ItemBonus[property] <= 0 || !_bonusesToBeDisplayed.Contains(property))
                     continue;
 
                 if (property is eProperty.PowerPool)