limit scope to preserve previous command-enter keystroke for Inspector

Author: taylordowns2000

assets/js/hooks/KeyHandlers.ts

@@ -429,13 +429,15 @@ const openRunPanelAction = (_e: KeyboardEvent, _el: HTMLElement) => {
 /**
  * Hook to open the Run panel when "Ctrl+Enter" (or "Cmd+Enter" on macOS) is pressed.
  *
- * This hook listens globally and navigates to the run panel URL, which opens the 
+ * This hook is scoped to the workflow editor and navigates to the run panel URL, which opens the 
  * workflow input interface for running the workflow.
  *
- * Priority: `PRIORITY.HIGH`, ensuring it takes precedence over the default run handlers.
+ * Priority: `PRIORITY.HIGH` within its scope, ensuring it takes precedence over other handlers in the workflow editor.
+ * Scope: `"workflow-editor"`, meaning this hook only applies within the workflow editor context.
  */
 export const OpenRunPanelViaCtrlEnter = createKeyCombinationHook(
   isCtrlOrMetaEnter,
   openRunPanelAction,
-  PRIORITY.HIGH
+  PRIORITY.HIGH,
+  'workflow-editor'
 );

lib/lightning_web/live/workflow_live/edit.ex

@@ -213,9 +213,11 @@ defmodule LightningWeb.WorkflowLive.Edit do
           class="transition-all duration-300 ease-in-out"
         />
         <div
-          class={"relative h-full flex grow transition-all duration-300 ease-in-out #{if @show_new_workflow_panel, do: "w-2/3", else: ""}"}
+          class={"relative h-full flex grow transition-all duration-300 ease-in-out #{if @show_new_workflow_panel, do: "w-2/3", else: ""} focus:outline-none"}
           id={"workflow-edit-#{@workflow.id}"}
           phx-hook="OpenRunPanelViaCtrlEnter"
+          data-keybinding-scope="workflow-editor"
+          tabindex="0"
         >
           <.selected_template_label
             :if={@selected_template && @show_new_workflow_panel}

test/lightning_web/live/workflow_live/edit_test.exs

@@ -3580,6 +3580,82 @@ defmodule LightningWeb.WorkflowLive.EditTest do
     end
   end
 
+    describe "keyboard shortcuts" do
+    setup %{project: project} do
+      workflow =
+        insert(:simple_workflow, project: project)
+        |> with_snapshot()
+      {:ok, workflow: workflow}
+    end
+
+    test "OpenRunPanelViaCtrlEnter hook is attached to workflow editor", %{
+      conn: conn,
+      project: project,
+      workflow: workflow
+    } do
+      {:ok, view, _html} =
+        live(
+          conn,
+          ~p"/projects/#{project.id}/w/#{workflow.id}",
+          on_error: :raise
+        )
+
+      # Check that the OpenRunPanelViaCtrlEnter hook is present on the workflow container
+      workflow_container = view |> element("#workflow-edit-#{workflow.id}")
+      assert has_element?(workflow_container)
+      assert render(workflow_container) =~ "phx-hook=\"OpenRunPanelViaCtrlEnter\""
+      assert render(workflow_container) =~ "data-keybinding-scope=\"workflow-editor\""
+    end
+
+    test "OpenRunPanelViaCtrlEnter hook is present with job selected", %{
+      conn: conn,
+      project: project,
+      workflow: workflow
+    } do
+      # Use the first job from the workflow that was created with snapshot
+      job = workflow.jobs |> List.first()
+
+      {:ok, view, _html} =
+        live(
+          conn,
+          ~p"/projects/#{project.id}/w/#{workflow.id}?s=#{job.id}",
+          on_error: :raise
+        )
+
+      # Hook should still be present when a job is selected
+      workflow_container = view |> element("#workflow-edit-#{workflow.id}")
+      assert has_element?(workflow_container)
+      assert render(workflow_container) =~ "phx-hook=\"OpenRunPanelViaCtrlEnter\""
+      assert render(workflow_container) =~ "data-keybinding-scope=\"workflow-editor\""
+
+      # Run button should be present for step-aware behavior
+      run_button = view |> element("#run-from-step-#{job.id}")
+      assert has_element?(run_button)
+    end
+
+    test "OpenRunPanelViaCtrlEnter hook is present in expand mode", %{
+      conn: conn,
+      project: project,
+      workflow: workflow
+    } do
+      # Use the first job from the workflow that was created with snapshot
+      job = workflow.jobs |> List.first()
+
+      {:ok, view, _html} =
+        live(
+          conn,
+          ~p"/projects/#{project.id}/w/#{workflow.id}?s=#{job.id}&m=expand",
+          on_error: :raise
+        )
+
+      # Hook should be present even in expand mode
+      workflow_container = view |> element("#workflow-edit-#{workflow.id}")
+      assert has_element?(workflow_container)
+      assert render(workflow_container) =~ "phx-hook=\"OpenRunPanelViaCtrlEnter\""
+      assert render(workflow_container) =~ "data-keybinding-scope=\"workflow-editor\""
+    end
+  end
+
   defp log_viewer_selected_level(log_viewer) do
     log_viewer
     |> render()