Remove the replicated and rename the webhook to generic term

Author: jyeshe

config/config.exs

@@ -25,7 +25,7 @@ config :lightning, LightningWeb.Endpoint,
   pubsub_server: Lightning.PubSub,
   live_view: [signing_salt: "EfrmuOUr"]
 
-config :lightning, Lightning.WebhookRateLimiter,
+config :lightning, Lightning.DistributedRateLimiter,
   start: false,
   capacity: 10,
   refill_per_second: 2

config/test.exs

@@ -53,7 +53,7 @@ config :lightning, LightningWeb.Endpoint,
     "/8zedVJLxvmGGFoRExE3e870g7CGZZQ1Vq11A5MbQGPKOpK57MahVsPW6Wkkv61n",
   server: true
 
-config :lightning, Lightning.WebhookRateLimiter, start: true
+config :lightning, Lightning.DistributedRateLimiter, start: true
 
 config :lightning, Lightning.Runtime.RuntimeManager,
   ws_url: "ws://localhost:4002/worker"

lib/lightning/application.ex

@@ -9,7 +9,7 @@ defmodule Lightning.Application do
 
   @rate_limiter_opts Application.compile_env!(
                        :lightning,
-                       Lightning.WebhookRateLimiter
+                       Lightning.DistributedRateLimiter
                      )
 
   @impl true
@@ -189,7 +189,7 @@ defmodule Lightning.Application do
     if @rate_limiter_opts[:start] do
       Horde.DynamicSupervisor.start_child(
         Lightning.DistributedSupervisor,
-        {Lightning.WebhookRateLimiter, @rate_limiter_opts}
+        {Lightning.DistributedRateLimiter, @rate_limiter_opts}
       )
     end
 

lib/lightning/webhook_rate_limiter.ex renamed to lib/lightning/distributed_rate_limiter.ex

@@ -1,4 +1,4 @@
-defmodule Lightning.WebhookRateLimiter do
+defmodule Lightning.DistributedRateLimiter do
   @moduledoc false
   use GenServer
 
@@ -98,8 +98,8 @@ defmodule Lightning.WebhookRateLimiter do
 
       {:allow, level}
     else
-      # can retry after 1 second
-      {:deny, 1}
+      wait_ms = 1_000 - (now - updated)
+      {:deny, wait_ms}
     end
   end
 

lib/lightning/extensions/rate_limiting.ex

@@ -8,6 +8,9 @@ defmodule Lightning.Extensions.RateLimiting do
   @type message :: Lightning.Extensions.Message.t()
 
   defmodule Context do
+    @moduledoc """
+    Context for the object (bucket) under rate limiting.
+    """
     @type t :: %Context{project_id: Ecto.UUID.t()}
 
     defstruct [:project_id]