Issue #156 - Change SSL help text to a Constant, remove NextGen branding and ads from the message

jonbartels · jonbartels · commit 33955eb962c4 · 2025-11-13T12:54:54.000-05:00
Signed-off-by: Jon Bartels &lt;jon.bartels@teladochealth.com&gt;
diff --git a/client/src/com/mirth/connect/client/ui/UIConstants.java b/client/src/com/mirth/connect/client/ui/UIConstants.java
@@ -129,4 +129,13 @@ public class UIConstants {
 
     // User preferences
     public static final String USER_PREF_KEY_BACKGROUND_COLOR = "backgroundColor";
+
+    // SSL Warning Text
+    // This text is used in the SSL Warning Panel for HTTP and WS connectors.
+    public static final String SSL_WARNING_TEXT = "<html>\n" +
+            "<body class=\"ssl-warning-panel\"><b><span style=\"color:#404040\">Important Notice:</span></b> This connection uses the java system trust store, which limits available TLS security options. \n" +
+            "Client certificate selection is not available in the UI when using the system store, preventing mutual TLS (mTLS) configuration through this interface.\n" +
+            "</body>\n" +
+            "</html>";
 }
+
diff --git a/client/src/com/mirth/connect/connectors/http/HttpSender.java b/client/src/com/mirth/connect/connectors/http/HttpSender.java
@@ -691,7 +691,7 @@ public ConnectorTypeDecoration getConnectorTypeDecoration() {
         }
 
         if (usingHttps) {
-            return new ConnectorTypeDecoration(Mode.DESTINATION, "(SSL Not Configured)", ICON_LOCK_X, SSL_TOOL_TIP, sslWarningPanel, COLOR_SSL_NOT_CONFIGURED);
+            return new ConnectorTypeDecoration(Mode.DESTINATION, "(SSL Not Configured)", UIConstants.ICON_INFORMATION, SSL_TOOL_TIP, sslWarningPanel, COLOR_SSL_NOT_CONFIGURED);
         } else {
             return new ConnectorTypeDecoration(Mode.DESTINATION);
         }
diff --git a/client/src/com/mirth/connect/connectors/http/SSLWarningPanel.java b/client/src/com/mirth/connect/connectors/http/SSLWarningPanel.java
@@ -25,6 +25,8 @@
 import com.mirth.connect.client.ui.BareBonesBrowserLaunch;
 import com.mirth.connect.client.ui.UIConstants;
 
+import static com.mirth.connect.client.ui.UIConstants.SSL_WARNING_TEXT;
+
 public class SSLWarningPanel extends JPanel implements HyperlinkListener {
 
     public SSLWarningPanel() {
@@ -42,7 +44,7 @@ public SSLWarningPanel() {
         editorPane.setBackground(getBackground());
         editorPane.setEditable(false);
         editorPane.addHyperlinkListener(this);
-        editorPane.setText("<html><body class=\"ssl-warning-panel\"><b><span style=\"color:#404040\">Important Notice:</span></b> The default system certificate store will be used for this connection. As a result, certain security options are not available and mutual authentication (two-way authentication) is not supported.<br/><br/>The <a href=\"https://www.nextgen.com/products-and-services/integration-engine#tab_extensions?extension=ssl-manager\">SSL Manager extension</a> for NextGen Connect provides advanced security and certificate management enhancements, including the ability to import certificates for use by source or destination connectors, as well as the ability to configure hostname verification and client authentication settings. For more information please contact <a href=\"https://www.nextgen.com/contact-us\">NextGen Healthcare sales</a>.</body></html>");
+        editorPane.setText(SSL_WARNING_TEXT);
         add(editorPane, "grow");
     }
 
diff --git a/client/src/com/mirth/connect/connectors/ws/SSLWarningPanel.java b/client/src/com/mirth/connect/connectors/ws/SSLWarningPanel.java
@@ -25,6 +25,8 @@
 import com.mirth.connect.client.ui.BareBonesBrowserLaunch;
 import com.mirth.connect.client.ui.UIConstants;
 
+import static com.mirth.connect.client.ui.UIConstants.SSL_WARNING_TEXT;
+
 public class SSLWarningPanel extends JPanel implements HyperlinkListener {
 
     public SSLWarningPanel() {
@@ -42,7 +44,7 @@ public SSLWarningPanel() {
         editorPane.setBackground(getBackground());
         editorPane.setEditable(false);
         editorPane.addHyperlinkListener(this);
-        editorPane.setText("<html><body class=\"ssl-warning-panel\"><b><span style=\"color:#404040\">Important Notice:</span></b> The default system certificate store will be used for this connection. As a result, certain security options are not available and mutual authentication (two-way authentication) is not supported.<br/><br/>The <a href=\"https://www.nextgen.com/products-and-services/integration-engine#tab_extensions?extension=ssl-manager\">SSL Manager extension</a> for NextGen Connect provides advanced security and certificate management enhancements, including the ability to import certificates for use by source or destination connectors, as well as the ability to configure hostname verification and client authentication settings. For more information please contact <a href=\"https://www.nextgen.com/contact-us\">NextGen Healthcare sales</a>.</body></html>");
+        editorPane.setText(SSL_WARNING_TEXT);
         add(editorPane, "grow");
     }
 
diff --git a/client/src/com/mirth/connect/connectors/ws/WebServiceSender.java b/client/src/com/mirth/connect/connectors/ws/WebServiceSender.java
@@ -80,10 +80,10 @@
 import com.mirth.connect.model.Connector.Mode;
 import com.mirth.connect.model.converters.ObjectXMLSerializer;
 import com.mirth.connect.util.ConnectionTestResponse;
+import com.mirth.connect.client.ui.UIConstants;
 
 public class WebServiceSender extends ConnectorSettingsPanel {
 
-    protected static final ImageIcon ICON_LOCK_X = new ImageIcon(Frame.class.getResource("images/lock_x.png"));
     protected static final Color COLOR_SSL_NOT_CONFIGURED = new Color(0xFFF099);
     protected static final String SSL_TOOL_TIP = "<html>The default system certificate store will be used for this connection.<br/>As a result, certain security options are not available and mutual<br/>authentication (two-way authentication) is not supported.</html>";
 
@@ -319,7 +319,7 @@ public void resetInvalidProperties() {
     @Override
     public ConnectorTypeDecoration getConnectorTypeDecoration() {
         if (isUsingHttps(wsdlUrlField.getText()) || isUsingHttps(String.valueOf(locationURIComboBox.getSelectedItem()))) {
-            return new ConnectorTypeDecoration(Mode.DESTINATION, "(SSL Not Configured)", ICON_LOCK_X, SSL_TOOL_TIP, sslWarningPanel, COLOR_SSL_NOT_CONFIGURED);
+            return new ConnectorTypeDecoration(Mode.DESTINATION, "(SSL Not Configured)", UIConstants.ICON_INFORMATION, SSL_TOOL_TIP, sslWarningPanel, COLOR_SSL_NOT_CONFIGURED);
         } else {
             return new ConnectorTypeDecoration(Mode.DESTINATION);
         }

Original file line number	Diff line number	Diff line change
`@@ -691,7 +691,7 @@ public ConnectorTypeDecoration getConnectorTypeDecoration() {`
`691`	`691`	`}`
`692`	`692`
`693`	`693`	`if (usingHttps) {`
`694`		`- return new ConnectorTypeDecoration(Mode.DESTINATION, "(SSL Not Configured)", ICON_LOCK_X, SSL_TOOL_TIP, sslWarningPanel, COLOR_SSL_NOT_CONFIGURED);`
	`694`	`+ return new ConnectorTypeDecoration(Mode.DESTINATION, "(SSL Not Configured)", UIConstants.ICON_INFORMATION, SSL_TOOL_TIP, sslWarningPanel, COLOR_SSL_NOT_CONFIGURED);`
`695`	`695`	`} else {`
`696`	`696`	`return new ConnectorTypeDecoration(Mode.DESTINATION);`
`697`	`697`	`}`