Fix desktop reading report output paths

Author: chengtan9907

deployments/desktop/shared/agents.py

@@ -465,7 +465,8 @@ def _reading_report_dirs() -> List[Path]:
     if _env_text("PAPERFLOW_READING_REPORTS_DIR", ""):
         return [configured] if configured.exists() and configured.is_dir() else [configured]
     fallback = (PROJECT_ROOT / "data" / "reading_reports").resolve()
-    ordered = [configured, fallback]
+    legacy_exports = (PROJECT_ROOT / "data" / "exports").resolve()
+    ordered = [configured, fallback, legacy_exports]
     results: List[Path] = []
     seen: Set[str] = set()
     for candidate in ordered:
@@ -857,6 +858,25 @@ def fake_create_doc(title: str, content: str, folder_id: Optional[str] = None) -
             reading_agent.create_doc = original
 
 
+@contextmanager
+def _reading_agent_output_env_patch():
+    """Expose GUI-derived output paths to reading-agent, which reads os.environ directly."""
+    patched = {
+        "PAPERFLOW_READING_REPORTS_DIR": _configured_path("PAPERFLOW_READING_REPORTS_DIR", "data/exports"),
+        "PAPERFLOW_PDF_DIR": _configured_path("PAPERFLOW_PDF_DIR", "data/exports"),
+    }
+    previous = {key: os.environ.get(key) for key in patched}
+    os.environ.update(patched)
+    try:
+        yield
+    finally:
+        for key, value in previous.items():
+            if value is None:
+                os.environ.pop(key, None)
+            else:
+                os.environ[key] = value
+
+
 def health() -> Dict[str, Any]:
     return {
         "ok": True,
@@ -2206,7 +2226,7 @@ def create_reading_reports(
     if not selected:
         return _reports_payload([], write_feishu_requested=should_write_feishu)
 
-    with _local_only_feishu_doc_patch(not should_write_feishu):
+    with _reading_agent_output_env_patch(), _local_only_feishu_doc_patch(not should_write_feishu):
         docs = reading_agent.create_reading_report(
             user_id=user_id,
             paper_ids=selected,
@@ -2262,7 +2282,7 @@ def read_arxiv(
 
     should_write_feishu = _env_bool("PAPERFLOW_WRITE_FEISHU", default=False) if write_feishu is None else bool(write_feishu)
     language = _normalize_response_language(response_language)
-    with _local_only_feishu_doc_patch(not should_write_feishu):
+    with _reading_agent_output_env_patch(), _local_only_feishu_doc_patch(not should_write_feishu):
         docs = reading_agent.create_reading_report(
             user_id=user_id,
             paper_ids=[],
@@ -2305,7 +2325,7 @@ def read_local_pdf(
     }
     should_write_feishu = _env_bool("PAPERFLOW_WRITE_FEISHU", default=False) if write_feishu is None else bool(write_feishu)
     language = _normalize_response_language(response_language)
-    with _local_only_feishu_doc_patch(not should_write_feishu):
+    with _reading_agent_output_env_patch(), _local_only_feishu_doc_patch(not should_write_feishu):
         docs = reading_agent.create_reading_report(
             user_id=user_id,
             paper_ids=[],

tests/test_desktop_gui.py

@@ -1365,6 +1365,39 @@ def test_desktop_github_sync_rebases_remote_changes_before_push(tmp_path, monkey
     assert (clone_check / "Daily Note - Jun 2026.md").exists()
 
 
+def test_desktop_reading_agent_receives_derived_output_dirs(tmp_path, monkeypatch: pytest.MonkeyPatch) -> None:
+    env_path = tmp_path / ".env"
+    notes_root = tmp_path / "Daily Note"
+    env_path.write_text(f'PAPERFLOW_NOTES_ROOT_DIR="{notes_root}"\n', encoding="utf-8")
+    monkeypatch.setattr(agents, "ENV_PATH", env_path)
+    monkeypatch.delenv("PAPERFLOW_NOTES_ROOT_DIR", raising=False)
+    monkeypatch.delenv("PAPERFLOW_READING_REPORTS_DIR", raising=False)
+    monkeypatch.delenv("PAPERFLOW_PDF_DIR", raising=False)
+
+    with agents._reading_agent_output_env_patch():  # noqa: SLF001 - output env bridge contract
+        assert agents.os.environ["PAPERFLOW_READING_REPORTS_DIR"] == str(notes_root)
+        assert agents.os.environ["PAPERFLOW_PDF_DIR"] == str(notes_root)
+
+    assert agents.os.environ.get("PAPERFLOW_READING_REPORTS_DIR") is None
+    assert agents.os.environ.get("PAPERFLOW_PDF_DIR") is None
+
+
+def test_desktop_report_dirs_include_legacy_exports_for_recent_generated_reports(tmp_path, monkeypatch: pytest.MonkeyPatch) -> None:
+    project_root = tmp_path / "project"
+    configured = tmp_path / "Daily Note"
+    legacy_exports = project_root / "data" / "exports"
+    configured.mkdir()
+    legacy_exports.mkdir(parents=True)
+    monkeypatch.setattr(agents, "PROJECT_ROOT", project_root)
+    monkeypatch.setattr(agents, "_configured_path", lambda _env_name, _default_relative: str(configured))
+    monkeypatch.setattr(agents, "_env_text", lambda _name, default="": "")
+
+    dirs = agents._reading_report_dirs()  # noqa: SLF001 - report discovery contract
+
+    assert configured.resolve() in dirs
+    assert legacy_exports.resolve() in dirs
+
+
 def test_desktop_daily_push_uses_saved_settings_when_gui_omits_filters(
     tmp_path, monkeypatch: pytest.MonkeyPatch
 ) -> None: