Fixes commented points in review

Author: AlejandroMunozManterola

CMakeLists.txt

@@ -9,7 +9,7 @@ project(dgtd)
 set(CMAKE_CXX_STANDARD 17)
 
 option(SEMBA_DGTD_ENABLE_MPI "Enable MPI support" OFF )
-option(SEMBA_DGTD_ENABLE_OPEN_MP "Enable OpenMP support" OFF )
+option(SEMBA_DGTD_ENABLE_OPENMP "Enable OpenMP support" OFF )
 option(SEMBA_DGTD_ENABLE_CUDA "Enable CUDA support" OFF )
 option(SEMBA_DGTD_ENABLE_PYTHON_BINDINGS "Enable Python bindings" OFF )
 option(SEMBA_DGTD_ENABLE_MFEM_AS_SUBDIRECTORY "Use MFEM as a subdirectory" ON )

src/CMakeLists.txt

@@ -3,13 +3,13 @@ if (SEMBA_DGTD_ENABLE_MPI)
 	add_compile_definitions(SEMBA_DGTD_ENABLE_MPI)
 endif()
 
-if (SEMBA_DGTD_ENABLE_OPEN_MP)
+if (SEMBA_DGTD_ENABLE_OPENMP)
 	FIND_PACKAGE(OpenMP REQUIRED)
 	IF(OpenMP_FOUND)
-		message(STATUS "SEMBA_DGTD_ENABLE_OPEN_MP:" ${SEMBA_DGTD_ENABLE_OPEN_MP})
+		message(STATUS "SEMBA_DGTD_ENABLE_OPENMP:" ${SEMBA_DGTD_ENABLE_OPENMP})
   		SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}")
  		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
-		add_compile_definitions(SEMBA_DGTD_ENABLE_OPEN_MP)
+		add_compile_definitions(SEMBA_DGTD_ENABLE_OPENMP)
 	endif()
 endif()
 

src/components/CMakeLists.txt

@@ -24,7 +24,7 @@ include_directories(${PARENT_DIR})
 
 target_link_libraries(maxwell-components mfem Eigen3::Eigen nlohmann_json)
 
-if (SEMBA_DGTD_ENABLE_OPEN_MP)
+if (SEMBA_DGTD_ENABLE_OPENMP)
 	message(STATUS "Linking maxwell-components with OpenMP libraries")
 	target_link_libraries(maxwell-components OpenMP::OpenMP_C OpenMP::OpenMP_CXX)
 endif()

src/components/RCSDataExtractor.cpp

@@ -1,5 +1,17 @@
 #include "RCSDataExtractor.h"
 
+#include <mfem.hpp>
+#include <filesystem>
+#include <fstream>
+#include <sstream>
+#include <iomanip> 
+
+#include "RCSManager.h"
+#include "SubMesher.h"
+#include "../test/TestUtils.h"
+#include "math/PhysicalConstants.h"
+#include "evolution/HesthavenEvolutionMethods.h"
+
 namespace maxwell {
 
 std::unique_ptr<SparseMatrix> assembleNtFFMatrix(FiniteElementSpace& fes) {

src/components/RCSDataExtractor.h

@@ -1,18 +1,6 @@
-#include <mfem.hpp>
-#include <filesystem>
-#include <fstream>
-#include <sstream>
-#include <iomanip>  
+#include <string>
 
-#include "RCSManager.h"
-#include "SubMesher.h"
-#include "../test/TestUtils.h"
-#include "math/PhysicalConstants.h"
-#include "evolution/HesthavenEvolutionMethods.h"
-
-namespace maxwell {
-
-using namespace mfem;
+ namespace maxwell {
 
 class RCSDataExtractor {
 public:

src/driver/CMakeLists.txt

@@ -10,7 +10,7 @@ target_link_libraries(maxwell-driver
 	nlohmann_json
 )
 
-if (SEMBA_DGTD_ENABLE_OPEN_MP)
+if (SEMBA_DGTD_ENABLE_OPENMP)
 	message(STATUS "Linking maxwell-driver with OpenMP libraries")
 	target_link_libraries(maxwell-driver OpenMP::OpenMP_C OpenMP::OpenMP_CXX)
 endif()

src/evolution/CMakeLists.txt

@@ -15,7 +15,7 @@ include_directories(${PARENT_DIR})
 
 target_link_libraries(maxwell-evolution maxwell-components mfem maxwell-mfemExtension Eigen3::Eigen)
 
-if (SEMBA_DGTD_ENABLE_OPEN_MP)
+if (SEMBA_DGTD_ENABLE_OPENMP)
 	message(STATUS "Linking maxwell-evolution with OpenMP libraries")
 	target_link_libraries(maxwell-evolution OpenMP::OpenMP_C OpenMP::OpenMP_CXX)
 endif()

src/launcher/CMakeLists.txt

@@ -7,7 +7,7 @@ target_link_libraries(opensemba_dgtd
 		mfem
 )
 
-if (SEMBA_DGTD_ENABLE_OPEN_MP)
+if (SEMBA_DGTD_ENABLE_OPENMP)
 	message(STATUS "Linking opensemba_dgtd with OpenMP libraries")
 	target_link_libraries(opensemba_dgtd OpenMP::OpenMP_C OpenMP::OpenMP_CXX)
 endif()

src/math/CMakeLists.txt

@@ -7,7 +7,7 @@ include_directories(${PARENT_DIR})
 
 target_link_libraries(maxwell-math mfem)
 
-if (SEMBA_DGTD_ENABLE_OPEN_MP)
+if (SEMBA_DGTD_ENABLE_OPENMP)
 	message(STATUS "Linking maxwell-math with OpenMP libraries")
 	target_link_libraries(maxwell-math OpenMP::OpenMP_C OpenMP::OpenMP_CXX)
 endif()

src/mfemExtension/CMakeLists.txt

@@ -8,7 +8,7 @@ add_library(maxwell-mfemExtension STATIC
 
 target_link_libraries(maxwell-mfemExtension mfem)
 
-if (SEMBA_DGTD_ENABLE_OPEN_MP)
+if (SEMBA_DGTD_ENABLE_OPENMP)
 	message(STATUS "Linking maxwell-mfemExtension with OpenMP libraries")
 	target_link_libraries(maxwell-mfemExtension OpenMP::OpenMP_C OpenMP::OpenMP_CXX)
 endif()