macOS buils fails for Sequoia

[diegofpb]

Hello,

I had difficulty compiling dablin on MacOS Sequoia, 15.2 (24C101). I followed the instructions in the README, installing the dependencies with Homebrew, but I kept getting this error:

$ sudo make                                                                                                    
[  9%] Built target fec
[ 13%] Built target rs_speedtest
[ 18%] Built target rstest
[ 20%] Building CXX object src/CMakeFiles/dablin.dir/sdl_output.cpp.o
In file included from /Users/diego/Developer/other-projects/dablin/src/sdl_output.cpp:19:
In file included from /Users/diego/Developer/other-projects/dablin/src/sdl_output.h:33:
/Users/diego/Developer/other-projects/dablin/src/tools.h:173:20: error: delegating constructors are permitted only in C++11
  173 |         AUDIO_SERVICE() : AUDIO_SERVICE(subchid_none, false) {}
      |                           ^~~~~~~~~~~~~
1 error generated.
make[2]: *** [src/CMakeFiles/dablin.dir/sdl_output.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/dablin.dir/all] Error 2
make: *** [all] Error 2

Could you let me know if I could fix it somehow?

Thanks :)

[diegofpb]

So I saw that adding add_compile_options(-std=c++11 -O2) in the CMakeLists.txt it enables the compilation, but I would not be very clear where in the file to add it so that it only happens in case of complication with macOS :)

[basicmaster]

Unfortunately I cannot test on MacOS myself, so you will have to help me :-)

Does your fix also work without -O2 (I suppose it will)?
Could you post the cmake output using an empty build folder?

[npm-sdr]

The patch below should fix this issue:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9328cf4..dcb1d7b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -49,7 +49,7 @@ endif()

Compiler specific setup

########################################################################

-if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
set(CMAKE_COMPILER_IS_CLANGXX 1)
endif()

[jacob-hofman]

I'm on Tahoe and I can confirm that, by following the instructions in the README, I can successfully build without other changes than the one in #80. CMAKE_CXX_COMPILER_ID still is AppleClang, so add_compile_options(-std=c++0x) is not applied, but nothing breaks anyway. Maybe some recent update to Clang fixed that? I thing this can be closed, @diegofpb can you confirm you're able to build on Mac now?