Skip to content

Conversation

@shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Nov 11, 2025

Changes

Contracts

Contract Address
OETHZapper 0xDA0485c1E74A7ef690E99D8286C243942eDAa07B

Governance

No governance action

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.86%. Comparing base (0ded59f) to head (55f2e09).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2703      +/-   ##
==========================================
- Coverage   40.49%   39.86%   -0.63%     
==========================================
  Files         124      124              
  Lines        5734     5734              
  Branches     1528     1528              
==========================================
- Hits         2322     2286      -36     
- Misses       3410     3446      +36     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36
Copy link
Collaborator

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Smoke tests pass after fork test execution of the governance proposal
Compared the "OETHZapper" contract with address 0xDA0485c1E74A7ef690E99D8286C243942eDAa07B on ethereum
to local files under folders ".,node_modules"

match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/interfaces/IWETH9.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/vault/AbstractOTokenZapper.sol
match   contracts/vault/OETHZapper.sol
match   contracts/vault/VaultStorage.sol
match   lib/openzeppelin/interfaces/IERC4626.sol

@sparrowDom
Copy link
Member

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Smoke tests pass after fork test execution of the governance proposal
Compared the "OETHZapper" contract with address 0xDA0485c1E74A7ef690E99D8286C243942eDAa07B on ethereum
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/interfaces/IWETH9.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/vault/AbstractOTokenZapper.sol
match   contracts/vault/OETHZapper.sol
match   contracts/vault/VaultStorage.sol
match   lib/openzeppelin/interfaces/IERC4626.sol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants