Commit ddef908
committed
Remove redundant/wrong
Redundant: Because `uv sync` will do this, and we run that as part of
`make check`.
Wrong: Because Python packages use PEP40 versions anyway, which aren't
always valid semvers, and they normalize semver to PEP40. This means
that by the time you pull the version from `importlib.metadata`, the
version number, which may have started as a valid semver (like
1.0.0-alpha-1) will have been transformed to PEP40 (like 1.0.0a1) and
produce a spurious build break.Makefile target check-versions
1 parent 71a1e75 commit ddef908
2 files changed
+0
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | 48 | | |
56 | 49 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
| |||
0 commit comments