Skip to content

Commit ddef908

Browse files
committed
Remove redundant/wrong Makefile target check-versions
Redundant: Because `uv sync` will do this, and we run that as part of `make check`. Wrong: Because Python packages use PEP40 versions anyway, which aren't always valid semvers, and they normalize semver to PEP40. This means that by the time you pull the version from `importlib.metadata`, the version number, which may have started as a valid semver (like 1.0.0-alpha-1) will have been transformed to PEP40 (like 1.0.0a1) and produce a spurious build break.
1 parent 71a1e75 commit ddef908

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

Makefile

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,5 @@ mypy: uv-sync
4545
| xargs uv run mypy --no-error-summary
4646
@uv run mypy --no-error-summary packages/*/tests/*.py
4747

48-
check-versions:
49-
@find packages -maxdepth 1 -type d -name "overture-schema*" \
50-
| sort \
51-
| tr - . \
52-
| sed 's|^packages/||' \
53-
| xargs uv run python -c 'import semver, sys; from importlib import metadata; [print(m, semver.VersionInfo.parse(metadata.version(m))) for m in sys.argv[1:]]'
54-
5548
reset-baseline-schemas:
5649
@find . -name \*_baseline_schema.json -delete

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ dev = [
5353
"pytest>=8.4.1",
5454
"pytest-cov>=7.0.0",
5555
"ruff>=0.12.4",
56-
"semver>=3.0.4"
5756
]
5857

5958
[tool.pytest.ini_options]

0 commit comments

Comments
 (0)