Fix flawed assertion

The assertion assertTrue(moduleId.hashCode() == other.hashCode() ==
expectedResult) is logically flawed. It incorrectly asserts that
unequal objects must have different hash codes, which is not
guaranteed by the hashCode() contract.

JIRA: LIGHTY-409
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>

Author: Tobianas

lighty-core/lighty-common/src/test/java/io/lighty/core/common/models/tests/YangModelUtilsTests.java

@@ -106,9 +106,12 @@ static Stream<Arguments> moduleIdStringInits() {
     void moduleIdEqualsTest(ModuleId moduleId, Object other, boolean expectedResult) {
         assertEquals(expectedResult, moduleId.equals(other));
         if (other != null) {
-            assertTrue(moduleId.hashCode() == other.hashCode() == expectedResult);
+            if (expectedResult) {
+                assertEquals(moduleId.hashCode(), other.hashCode(),
+                    "Equal objects must have equal hash codes");
+            }
         } else {
-            assertFalse(expectedResult);
+            assertFalse(expectedResult, "An object should never be equal to null");
         }
     }