Skip to content

Commit af4f3de

Browse files
authored
Improve error handling when spec isn't valid (#1200)
Check for validation results that will result in an error and reject with that error. Also, add additional safety around the `conversionResult` handling to avoid generic errors on failure.
1 parent 44f3869 commit af4f3de

File tree

1 file changed

+8
-2
lines changed
  • packages/docusaurus-plugin-openapi-docs/src/openapi

1 file changed

+8
-2
lines changed

packages/docusaurus-plugin-openapi-docs/src/openapi/openapi.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,15 @@ function jsonToCollection(data: OpenApiObject): Promise<Collection> {
4343
{ schemaFaker: false }
4444
);
4545
schemaPack.computedOptions.schemaFaker = false;
46+
47+
// Make sure the schema was properly validated or reject with error
48+
if (!schemaPack.validationResult?.result) {
49+
return reject(schemaPack.validationResult?.reason);
50+
}
51+
4652
schemaPack.convert((_err: any, conversionResult: any) => {
47-
if (!conversionResult.result) {
48-
return reject(conversionResult.reason);
53+
if (_err || !conversionResult.result) {
54+
return reject(_err || conversionResult.reason);
4955
}
5056
return resolve(new sdk.Collection(conversionResult.output[0].data));
5157
});

0 commit comments

Comments
 (0)