Add missing base types + hide unique only bases from crafter#2111
Merged
Conversation
GGG now use many unique item only base types for the new 0.5 uniques So they don't clutter up the item crafter with invalid bases we now mark base types that contain "Runemastered" or "Unique" in their name / baseType name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2112
Description of the problem being solved:
GGG now use many unique item-only base types for the new 0.5 uniques
So they don't clutter up the item crafter with invalid bases, we now mark base types that contain "Runemastered" or "Unique" in their name / baseType name
This also fixes many of the new uniques not importing at all into PoB
Also fixes Talisman bases not have a base socket count
Before screenshot:
After screenshot: