Update to Omnipay 3

Author: leith

.travis.yml

@@ -2,20 +2,16 @@ language: php
 
 dist: trusty
 php:
+  - "7.4"
+  - "7.3"
   - "7.2"
   - "7.1"
   - "7.0"
   - "5.6"
-  - "5.5"
-  - "5.4"
-
-matrix:
-  include:
-    - php: "5.3"
-      dist: precise
 
 before_script:
-  - composer install -n --dev --prefer-source
+  - travis_retry composer self-update
+  - travis_retry composer install --no-interaction --dev --prefer-source
 
 script:
   - vendor/bin/phpcs --standard=PSR2 src

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2019 Leith Caldwell
+Copyright (c) 2020 Leith Caldwell
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

README.md

@@ -11,7 +11,7 @@
 
 
 [Omnipay](https://github.com/thephpleague/omnipay) is a framework agnostic, multi-gateway payment
-processing library for PHP 5.3+. This package implements CyberSource support for Omnipay. It includes
+processing library for PHP 5.6+. This package implements CyberSource support for Omnipay. It includes
 support for the Secure Acceptance Hosted Checkout (formerly Web/Mobile) version of the gateway.
 
 ## Installation
@@ -22,7 +22,7 @@ to your `composer.json` file:
 ```json
 {
     "require": {
-        "PatronBase/omnipay-cybersource-hosted": "~2.0"
+        "PatronBase/omnipay-cybersource-hosted": "~3.0"
     }
 }
 ```

composer.json

@@ -32,14 +32,16 @@
         "psr-4": { "Omnipay\\CyberSource\\" : "tests/" }
     },
     "require": {
-        "omnipay/common": "~2.0"
+        "omnipay/common": "~3.0"
     },
     "require-dev": {
-        "omnipay/tests": "~2.0"
+        "omnipay/tests": "~3.0",
+        "squizlabs/php_codesniffer": "^3.5"
     },
     "extra": {
         "branch-alias": {
-            "dev-master": "2.0.x-dev"
+            "dev-master": "3.0.x-dev"
         }
-    }
+    },
+    "prefer-stable": true
 }

phpunit.xml.dist

@@ -17,9 +17,6 @@
             <directory>./tests/</directory>
         </testsuite>
     </testsuites>
-    <listeners>
-        <listener class="Mockery\Adapter\Phpunit\TestListener" file="vendor/mockery/mockery/library/Mockery/Adapter/Phpunit/TestListener.php" />
-    </listeners>
     <filter>
         <whitelist>
             <directory>./src</directory>

src/Message/CompletePurchaseResponse.php

@@ -44,7 +44,7 @@ public function __construct(RequestInterface $request, $data)
 
     /**
      * Is the response successful?
-     * 
+     *
      * Possible values: 'ACCEPT', 'DECLINE', 'REVIEW', 'ERROR', 'CANCEL'
      *
      * @return boolean

src/Message/PurchaseResponse.php

@@ -3,11 +3,12 @@
 namespace Omnipay\CyberSource\Message;
 
 use Omnipay\Common\Message\AbstractResponse;
+use Omnipay\Common\Message\RedirectResponseInterface;
 
 /**
  * CyberSource Purchase Response
  */
-class PurchaseResponse extends AbstractResponse
+class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
 {
     public function isSuccessful()
     {

tests/Message/CompletePurchaseResponseTest.php

@@ -249,23 +249,25 @@ public function testCompletePurchaseError()
     }
 
     /**
-     * @expectedException         Omnipay\Common\Exception\InvalidResponseException
-     * @expectedExceptionMessage  Invalid response from payment gateway (no data)
+     * @doesNotPerformAssertions
      */
     public function testCompletePurchaseInvalidNoParameters()
     {
+        $this->expectException('Omnipay\Common\Exception\InvalidResponseException');
+        $this->expectExceptionMessage('Invalid response from payment gateway (no data)');
         $this->response = new CompletePurchaseResponse(
             $this->getMockRequest(),
             array()
         );
     }
 
     /**
-     * @expectedException         Omnipay\Common\Exception\InvalidResponseException
-     * @expectedExceptionMessage  Invalid response from payment gateway (no data)
+     * @doesNotPerformAssertions
      */
     public function testCompletePurchaseInvalidNoDecision()
     {
+        $this->expectException('Omnipay\Common\Exception\InvalidResponseException');
+        $this->expectExceptionMessage('Invalid response from payment gateway (no data)');
         $this->response = new CompletePurchaseResponse(
             $this->getMockRequest(),
             array(
@@ -276,11 +278,12 @@ public function testCompletePurchaseInvalidNoDecision()
     }
 
     /**
-     * @expectedException         Omnipay\Common\Exception\InvalidResponseException
-     * @expectedExceptionMessage  Invalid response from payment gateway (no data)
+     * @doesNotPerformAssertions
      */
     public function testCompletePurchaseInvalidNoSignatureDefinition()
     {
+        $this->expectException('Omnipay\Common\Exception\InvalidResponseException');
+        $this->expectExceptionMessage('Invalid response from payment gateway (no data)');
         $this->response = new CompletePurchaseResponse(
             $this->getMockRequest(),
             array(
@@ -291,11 +294,12 @@ public function testCompletePurchaseInvalidNoSignatureDefinition()
     }
 
     /**
-     * @expectedException         Omnipay\Common\Exception\InvalidResponseException
-     * @expectedExceptionMessage  Invalid response from payment gateway (no data)
+     * @doesNotPerformAssertions
      */
     public function testCompletePurchaseInvalidNoSignature()
     {
+        $this->expectException('Omnipay\Common\Exception\InvalidResponseException');
+        $this->expectExceptionMessage('Invalid response from payment gateway (no data)');
         $this->response = new CompletePurchaseResponse(
             $this->getMockRequest(),
             array(
@@ -306,27 +310,30 @@ public function testCompletePurchaseInvalidNoSignature()
     }
 
     /**
-     * @expectedException         Omnipay\Common\Exception\InvalidResponseException
-     * @expectedExceptionMessage  Invalid response from payment gateway (no data)
+     * @doesNotPerformAssertions
      */
     public function testCompletePurchaseInvalidEmptySignature()
     {
+        $this->expectException('Omnipay\Common\Exception\InvalidResponseException');
+        $this->expectExceptionMessage('Invalid response from payment gateway (no data)');
         $this->response = new CompletePurchaseResponse(
             $this->getMockRequest(),
             array(
                 'decision' => 'ERROR',
                 'signed_field_names' => 'decision',
                 'signature' => '',
-           )
+            )
         );
     }
 
     /**
-     * @expectedException         Omnipay\Common\Exception\InvalidResponseException
-     * @expectedExceptionMessage  Invalid response from payment gateway (signature mismatch)
+     * @doesNotPerformAssertions
      */
     public function testCompletePurchaseInvalidSignature()
     {
+        $this->expectException('Omnipay\Common\Exception\InvalidResponseException');
+        $this->expectExceptionMessage('Invalid response from payment gateway (signature mismatch)');
+
         $this->getMockRequest()->shouldReceive('getSecretKey')->once()->andReturn($this->testSecretKey);
 
         $this->response = new CompletePurchaseResponse(