Skip to content

Commit df7cf94

Browse files
committed
Improved MAINTAINERS.md
1 parent d9868c7 commit df7cf94

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

MAINTAINERS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,29 +40,29 @@ A simple, easy question you know the answer to and is a short answer can be answ
4040

4141
It is a good idea to answer people's questions related to the design of Compose by directing them with a quote and/or link to the part of the README or CONTRIBUTING file that answers their question or is related to their question.
4242

43-
If there is no such documentation to point them to and their question is a sensible questions that it would be good to answer, then fantastic, a gap in the documentation has been found and an issue should be created to address this so this documentation is created.
43+
If there is no such documentation to point them to and their question is a sensible question, then fantastic, a gap in the documentation has been found and an issue should be created to address this so this documentation is created.
4444

4545
## Review and merge pull requests
4646

4747
This is something I really need help with. It is a bottleneck for the project unless we have enough people doing this. Fortunately this is fun work.
4848

4949
Only work on pull requests that you want to work on. If you don't feel you should handle a particular pull request for some reason, don't work on it. If you only want to review a pull request and give feedback on it, but not merge it, that's great. Do what you feel is right for yourself and the project.
5050

51-
Assign to yourself a pull request that you are reviewing so others know it is being reviewed. More than one person or maintainer can review the same pull request at the same time. Depending on the pull request, and the context, it can be important that more than one maintainer reviews it.
51+
Assign to yourself a pull request that you are reviewing so others know it is being reviewed. More than one person or maintainer can review the same pull request at the same time. Depending on the pull request, and the context, it can be beneficial that more than one maintainer reviews it.
5252

5353
Before merging a pull request look at all the data concerning the pull request. Look at the code in the pull request and see if it makes sense.
5454

5555
Every pull request is different and so use your judgement about what should be done about each individual pull request.
5656

5757
Be really nice to people who submit pull requests even if there are a lot of problems with what they submit. But never merge a pull request because you are being nice. If there is something wrong, give feedback about it politely.
5858

59-
I extremely appreciate people who submit a pull request because they want to help our project, even if there are a lot of problems with what they submit.
59+
I extremely appreciate people who submit a pull request because they want to help our project.
6060

6161
**As maintainers we are responsible for the quality of Compose.**
6262

6363
## Maintain communication about the project
6464

65-
Share with people what is going on. It is great to highlight other's work in our project any way we can.
65+
Share with people what is going on. It is great to highlight other's work in our project.
6666

6767
Join the private discord channel for maintainers.
6868

0 commit comments

Comments
 (0)