From c2356b51ea1bff0b8e179f975cc4bd8ca5f5162d Mon Sep 17 00:00:00 2001 From: Maxime Normandin Date: Sun, 26 Oct 2025 11:33:32 -0400 Subject: [PATCH 1/4] make slither fail only on high impact errors --- .github/workflows/slither.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml index 6026b044..07625757 100644 --- a/.github/workflows/slither.yml +++ b/.github/workflows/slither.yml @@ -32,4 +32,4 @@ jobs: - name: Run Slither analysis run: | - slither . --exclude-dependencies \ No newline at end of file + slither . --exclude-dependencies --fail-high \ No newline at end of file From 1f4004342169a51b3f6b1c71c207561738cdf721 Mon Sep 17 00:00:00 2001 From: Maxime Normandin Date: Sun, 26 Oct 2025 11:40:13 -0400 Subject: [PATCH 2/4] make slither silent, only for reporting --- .github/workflows/slither.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml index 07625757..84efe70c 100644 --- a/.github/workflows/slither.yml +++ b/.github/workflows/slither.yml @@ -30,6 +30,7 @@ jobs: run: | pip install slither-analyzer + # Slither analysis ONLY FOR REPORTING PURPOSES - name: Run Slither analysis run: | - slither . --exclude-dependencies --fail-high \ No newline at end of file + slither . --exclude-dependencies --fail-none \ No newline at end of file From b2546d261e2582e84d36ff466348f04fe2badcba Mon Sep 17 00:00:00 2001 From: Maxime Normandin Date: Sun, 26 Oct 2025 11:43:32 -0400 Subject: [PATCH 3/4] remove space on PR template --- .github/pull_request_template.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 67e213c1..16305ed8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,6 @@ ## Changes Made - ## Checklist @@ -26,5 +25,4 @@ Before submitting this PR, please ensure: Make sure to follow the [CONTRIBUTING.md](https://github.com/Perfect-Abstractions/Compose/blob/main/CONTRIBUTING.md) guidelines. ## Additional Notes - From 9798ea4843e5f1b696b7c5b9bc07fc8332810576 Mon Sep 17 00:00:00 2001 From: Maxime Normandin Date: Sun, 26 Oct 2025 11:56:18 -0400 Subject: [PATCH 4/4] fix fmt --- src/diamond/DiamondCutFacet.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/diamond/DiamondCutFacet.sol b/src/diamond/DiamondCutFacet.sol index 07d32583..cdbef263 100644 --- a/src/diamond/DiamondCutFacet.sol +++ b/src/diamond/DiamondCutFacet.sol @@ -108,7 +108,7 @@ contract DiamondCutFacet { bytes4 lastSelector = ds.selectors[selectorCount]; ds.selectors[oldFacetAddressAndSelectorPosition.selectorPosition] = lastSelector; ds.facetAddressAndSelectorPosition[lastSelector].selectorPosition = - oldFacetAddressAndSelectorPosition.selectorPosition; + oldFacetAddressAndSelectorPosition.selectorPosition; } // delete last selector ds.selectors.pop();