Fix issue with shield damage modifiers potentially under/overflowing shield damage

Author: Starkku

src/New/Entity/ShieldClass.cpp

@@ -215,8 +215,8 @@ int ShieldClass::ReceiveDamage(args_ReceiveDamage* args)
 	const int originalShieldDamage = shieldDamage;
 	const int min = pWHExt->Shield_ReceivedDamage_Minimum.Get(pType->ReceivedDamage_Minimum);
 	const int max = pWHExt->Shield_ReceivedDamage_Maximum.Get(pType->ReceivedDamage_Maximum);
-	const int minDmg = static_cast<int>(min * pWHExt->Shield_ReceivedDamage_MinMultiplier);
-	const int maxDmg = static_cast<int>(max * pWHExt->Shield_ReceivedDamage_MaxMultiplier);
+	const int minDmg = GeneralUtils::SafeMultiply(min, pWHExt->Shield_ReceivedDamage_MinMultiplier);
+	const int maxDmg = GeneralUtils::SafeMultiply(max, pWHExt->Shield_ReceivedDamage_MaxMultiplier);
 	shieldDamage = Math::clamp(shieldDamage, minDmg, maxDmg);
 
 	if (Phobos::DisplayDamageNumbers && shieldDamage != 0)

src/Utilities/GeneralUtils.cpp

@@ -296,3 +296,27 @@ int GeneralUtils::GetColorFromColorAdd(int colorIndex)
 
 	return colorValue;
 }
+
+int GeneralUtils::SafeMultiply(int value, int mult)
+{
+	long long product = static_cast<long long>(value) * mult;
+
+	if (product > INT32_MAX)
+		product = INT32_MAX;
+	else if (product < INT32_MIN)
+		product = INT32_MIN;
+
+	return static_cast<int>(product);
+}
+
+int GeneralUtils::SafeMultiply(int value, double mult)
+{
+	double product = static_cast<double>(value) * mult;
+
+	if (product > INT32_MAX)
+		product = INT32_MAX;
+	else if (product < INT32_MIN)
+		product = INT32_MIN;
+
+	return static_cast<int>(product);
+}

src/Utilities/GeneralUtils.h

@@ -39,6 +39,8 @@ class GeneralUtils
 	static CoordStruct CalculateCoordsFromDistance(CoordStruct currentCoords, CoordStruct targetCoords, int distance);
 	static void DisplayDamageNumberString(int damage, DamageDisplayType type, CoordStruct coords, int& offset);
 	static int GetColorFromColorAdd(int colorIndex);
+	static int SafeMultiply(int value, int mult);
+	static int SafeMultiply(int value, double mult);
 	static DynamicVectorClass<ColorScheme*>* BuildPalette(const char* paletteFileName);
 
 	template<typename T>