Skip to content

Commit d1680bd

Browse files
committed
fix: rename VERSION to .version to avoid C++ header conflict
On macOS's case-insensitive filesystem, the VERSION file conflicts with the C++ standard library header <version> (C++20). When the compiler tries to #include <version>, it picks up our VERSION file instead, causing compilation errors. Solution: Rename VERSION to .version (hidden file with dot prefix) Updated: - CMakeLists.txt: Read from .version instead of VERSION - update_versions.py: Write to .version - release-please.yml: Upload .version as asset - release-please-config.json: Track .version in extra-files This is a known issue on case-insensitive filesystems: llvm/llvm-project#51214
1 parent aac9475 commit d1680bd

File tree

339 files changed

+89576
-10
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

339 files changed

+89576
-10
lines changed

.github/workflows/release-please.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ jobs:
4646
python scripts/update_versions.py --version ${{ steps.release.outputs.version }}
4747
echo "Updated version files to ${{ steps.release.outputs.version }}"
4848
49-
- name: Upload VERSION file as release asset
49+
- name: Upload .version file as release asset
5050
if: ${{ steps.release.outputs.release_created }}
5151
env:
5252
GH_TOKEN: ${{ github.token }}
5353
run: |
54-
gh release upload ${{ steps.release.outputs.tag_name }} VERSION --clobber
54+
gh release upload ${{ steps.release.outputs.tag_name }} .version --clobber
5555
5656
trigger-publish:
5757
needs: release-please
File renamed without changes.

0 commit comments

Comments
 (0)