refactor(scheduler): replace goto with error handling function #1421
Conversation
Signed-off-by: yxxhero <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yxxhero The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
kind/enhancement
Summary of ChangesHello @yxxhero, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the 'scheduler' component by refactoring its error handling logic. Specifically, it eliminates the use of 'goto' statements in the 'Bind' function, replacing them with a more structured and readable approach using a local helper function. Additionally, it includes routine updates to the project's Go module dependencies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: yxxhero <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the scheduler's Bind function to remove a goto statement, replacing it with a closure for error handling and cleanup. This is a good improvement for code readability and maintainability. Additionally, it corrects the return values in getNodesUsage on an error path to be more idiomatic. I've found one issue where an error is not handled during lock release, which could lead to silent failures.
| klog.InfoS("Release node locks", "node", args.Node) | ||
| for _, val := range device.GetDevices() { | ||
| val.ReleaseNodeLock(node, current) | ||
| } |
There was a problem hiding this comment.
The error returned by val.ReleaseNodeLock(node, current) is ignored. If releasing the lock fails, it could fail silently and leave the node in a locked state, preventing other pods from being scheduled on it. This error should be logged.
if releaseErr := val.ReleaseNodeLock(node, current); releaseErr != nil {
klog.ErrorS(releaseErr, "Failed to release node lock", "node", args.Node, "device", val)
}
There was a problem hiding this comment.
please adopt this suggestion
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: yxxhero <[email protected]>
|
please resolve this conflict |
| } | ||
|
|
||
| // Function to release node locks in case of binding failure | ||
| releaseNodeLocks := func() (*extenderv1.ExtenderBindingResult, error) { |
There was a problem hiding this comment.
@yxxhero Is it possible to using a defer statement to improve code clarity and maintainability ?
3 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
cleanup goto
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: