Skip to content

Commit 6da0765

Browse files
committed
fix: Select with filter doesn't work if the value of the field 'value' is falsy
1 parent 93c7015 commit 6da0765

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# v1.1.1
2+
3+
- Fix: Select with filter doesn't work if the value of the field 'value' is falsy
4+
15
# v1.1.0
26

37
- Feat: Better type on BaseModel creation

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "promiseorm",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"description": "A Typescript ORM for automatic creation and management of models and entries from simple objects",
55
"main": "build/index.js",
66
"files": [

src/main/interfaces/database/IDatabaseField.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export type IDatabaseField =
1212
| {
1313
type: EDatabaseTypes.BOOLEAN;
1414
nullable: boolean;
15-
default?: any;
15+
default?: boolean;
1616
autoIncrement?: boolean;
1717
primaryKey?: boolean;
1818
foreignKey?: ForeignKeyOptions;
@@ -23,7 +23,7 @@ export type IDatabaseField =
2323
minSize?: number;
2424
nullable: boolean;
2525
unique?: boolean;
26-
default?: any;
26+
default?: Date | 'CURRENT_TIMESTAMP()' | 'CURRENT_TIMESTAMP() ON UPDATE CURRENT_TIMESTAMP()';
2727
autoIncrement?: boolean;
2828
primaryKey?: boolean;
2929
foreignKey?: ForeignKeyOptions;

src/main/models/BaseModel.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ export class BaseModel {
128128
this.filterCheck(filterElement as IDatabaseQueryFilterExpression);
129129
} else {
130130
if (
131-
!(filterElement as IDatabaseQueryFilter).operator ||
132-
!(filterElement as IDatabaseQueryFilter).tableKey ||
133-
!(filterElement as IDatabaseQueryFilter).value
131+
(filterElement as IDatabaseQueryFilter).operator == null ||
132+
(filterElement as IDatabaseQueryFilter).tableKey == null ||
133+
(filterElement as IDatabaseQueryFilter).value === undefined
134134
)
135135
throw new DatabaseException('Filter must have operator, tableKey and value!');
136136
if (

0 commit comments

Comments
 (0)