Quameter/peak symmetry #3271
Open
Quameter/peak symmetry #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it anyway and this will make tab completion easier on Linux and MacOS
mayo/gitignore updates
Author
|
Anything I can do to move this pull request forward? |
Member
|
Sorry for the big delay reviewing this. Please revert the whitespace changes to make the changes easier to review and while you're at it remove the // BEG and //END comments (if I want to know where some code came from I'll just use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Helps ascertain if there are disproportionately more MS2 triggers which in turn inflates the spectral counts for that protein.
This alters the ability to assess peak area and contributes to more variability in the assays.
We would hope for more peaks to be centered near the 1-line (line slope=1).
A convenient Jupyter notebook for example plotting is available from [email protected] .
Less changes would have been necessary if not for the near duplicate data structures (i.e. SlimCrawPeak,
CrawPeak, Peak, CrawdadPeak).