-
Notifications
You must be signed in to change notification settings - Fork 111
Carafe Integration #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dshteyn
wants to merge
498
commits into
master
Choose a base branch
from
Skyline/work/20250226_CarafeSupport
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Carafe Integration #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dshteyn
commented
Jul 18, 2025
- Integrate carafe.
- Add a test to run carafe.
- Expose some basic user options for AlphaPeptDeep.
…ring by ProcessRunner for Immediate Window output cleanliness.
…ported mods GetWarningMods when building a library.
…es predicted by AlphaPeptDeep run by Skyline. Fix problem when using paths with bad legacy character combos. Code cleanup.
…nd IM. Multiply AlphaPeptDeep NORMALIZED_RT by 100 for scaling as suggested by Brendan
…uildLibraryDlg, Dispose dialog instead in PythonInstallerUI. Bugfix CPU fallback for running library build when user answers "No" to Nvidia Libraries. Make variable name more descriptive for tracking user's answer to Nvidia admin elevation requirement.
…support' of https://github.com/ProteoWizard/pwiz into pwiz-CarafeSupport-Feb262025 # Resolved Conflicts: # pwiz_tools/Shared/CommonUtil/SystemUtil/ProcessRunner.cs # pwiz_tools/Skyline/Model/AlphaPeptDeep/AlphapeptdeepLibraryBuilder.cs # pwiz_tools/Skyline/Model/Carafe/CarafeLibraryBuilder.cs # pwiz_tools/Skyline/SettingsUI/BuildLibraryDlg.resx
…support' of https://github.com/ProteoWizard/pwiz into pwiz-CarafeSupport-Feb262025 # Resolved: # pwiz_tools/Skyline/SettingsUI/BuildLibraryDlg.cs # pwiz_tools/Skyline/ToolsUI/PythonInstallerUI.cs
…support' of https://github.com/ProteoWizard/pwiz into pwiz-CarafeSupport-Feb262025
…released file locks after running APD build library test.
…yline/work/20240816_pythoninstaller_with_virtual_env_support
… comparisons as these number are now multiplied by 10^2 before writing, adjust the tolerance from 10^-3 to 10^-1
…_virtual_env_support
… APDBuildLibraryTest
…support' of https://github.com/ProteoWizard/pwiz into Skyline/work/20240816_pythoninstaller_with_virtual_env_support
…a test directory.
…support' of https://github.com/ProteoWizard/pwiz into pwiz-CarafeSupport-Feb262025 # Merged Conflict: # pwiz_tools/Skyline/Model/Tools/PythonInstaller.cs
…on Mobility predictions with AlphaPeptDeep
…yline/work/20250226_CarafeSupport
…com/ProteoWizard/pwiz into Skyline/work/20250226_CarafeSupport
…com/ProteoWizard/pwiz into Skyline/work/20250226_CarafeSupport
…yline/work/20250226_CarafeSupport
Zip file now has separate folders for expected files and rawdata.
…yline/work/20250226_CarafeSupport
…com/nickshulman/pwiz into Skyline/work/20250226_CarafeSupport
…yline/work/20250226_CarafeSupport
…yline/work/20250226_CarafeSupport
…yline/work/20250226_CarafeSupport
…yline/work/20250226_CarafeSupport
…yline/work/20250226_CarafeSupport
…k/20250226_CarafeSupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.