Enable TruffleHog in pre-commit #439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@cursor review |
Contributor
Author
|
Gentle ping @davidberenstein1957 Could you please review? |
davidberenstein1957
requested review from
davidberenstein1957 and
minettekaum
| - id: trufflehog | ||
| name: TruffleHog Secrets Scanner | ||
| entry: trufflehog | ||
| language: golang |
Member
There was a problem hiding this comment.
why are we setting this to golang?
Contributor
Author
There was a problem hiding this comment.
Since trufflehog is a package written in golang, we have to specify the language for the hook to run.
| name: TruffleHog Secrets Scanner | ||
| entry: trufflehog | ||
| language: golang | ||
| types_or: [python, yaml, json, text] |
Member
There was a problem hiding this comment.
Any reason for this specific config?
Contributor
Author
There was a problem hiding this comment.
In types_or we define the types of program files for scanning using trufflehog. Do you think we need to define additional file types?
davidberenstein1957
approved these changes
Nov 27, 2025
Contributor
Author
|
Could you please review? cc: @minettekaum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up PR which includes files like
.pyor.mdfor scanning and have not linted any files as advised. Currently, the pre-commit hook for trufflehog fails with a package not installed warning. Since it is a golang package, I have adjusted the configuration for it to work. It currently scanssrc,testsand.github/workflowsin order for the checks to be completed in a reasonable amount of time.Could you please review?
cc: @davidberenstein1957
Related Issue
Fixes #(issue number)
Type of Change
How Has This Been Tested?
Checklist
Additional Notes