Add Ell14K rotator driver #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-Nussbaum
force-pushed
the
master
branch
from
612b1e2 to
3b6e1d1
Compare
SoroushHoseini
force-pushed
the
add_ellipticrotator
branch
from
e6f8334 to
77f2623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.thorlabs.com/thorproduct.cfm?partnumber=ELL14K
For the the above motor, I added a device driver.
Motivation and Context
In order to execute tomographies and other protocols in pqn, we need more motors, as in the ELL14k motors in the tomography setup currently in lab.
How have these changes been tested?
Tested that the motors work with the added device driver class, and the motor moves to the correct angle set by the class.
Types of changes
Checklist: