Skip to content

Commit 1c18422

Browse files
CopilotPuchaczov
Copilot
and
Puchaczov
authored
Fix all compilation warnings in Musoq project (#109)
* Initial plan * Fix all compilation warnings - nullable references, string comparison, and NuGet license Co-authored-by: Puchaczov <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Puchaczov <[email protected]> Co-authored-by: Jakub Puchała <[email protected]>
1 parent 9d4076a commit 1c18422

File tree

11 files changed

+22
-22
lines changed

11 files changed

+22
-22
lines changed

‎Musoq.Converter/Musoq.Converter.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<Authors>Jakub Puchała</Authors>
88
<Product>Musoq</Product>
99
<PackageProjectUrl>https://github.com/Puchaczov/Musoq</PackageProjectUrl>
10-
<PackageLicenseUrl>https://github.com/Puchaczov/Musoq/blob/master/LICENSE</PackageLicenseUrl>
10+
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1111
<PackageTags>sql, dotnet-core</PackageTags>
1212
<PublishRepositoryUrl>true</PublishRepositoryUrl>
1313
<IncludeSymbols>true</IncludeSymbols>

‎Musoq.Evaluator.Tests/CrossApplyCteTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ with p as (
276276
);
277277

278278
// Verify count of appearances
279-
Assert.AreEqual(3, actualPairs.Count(p => p.Name == name),
279+
Assert.AreEqual(3, actualPairs.Count(p => (string)p.Name == name),
280280
$"{name} should appear exactly 3 times");
281281
}
282282
}

‎Musoq.Evaluator/Musoq.Evaluator.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<Authors>Jakub Puchała</Authors>
88
<Product>Musoq</Product>
99
<PackageProjectUrl>https://github.com/Puchaczov/Musoq</PackageProjectUrl>
10-
<PackageLicenseUrl>https://github.com/Puchaczov/Musoq/blob/master/LICENSE</PackageLicenseUrl>
10+
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1111
<PackageTags>sql, dotnet-core</PackageTags>
1212
<PublishRepositoryUrl>true</PublishRepositoryUrl>
1313
<IncludeSymbols>true</IncludeSymbols>

‎Musoq.Parser/Musoq.Parser.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<Authors>Jakub Puchała</Authors>
88
<Product>Musoq</Product>
99
<PackageProjectUrl>https://github.com/Puchaczov/Musoq</PackageProjectUrl>
10-
<PackageLicenseUrl>https://github.com/Puchaczov/Musoq/blob/master/LICENSE</PackageLicenseUrl>
10+
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1111
<PackageTags>sql, dotnet-core</PackageTags>
1212
<PublishRepositoryUrl>true</PublishRepositoryUrl>
1313
<IncludeSymbols>true</IncludeSymbols>

‎Musoq.Plugins.Tests/BytesTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ public class BytesTests : LibraryBaseBaseTests
1010
[TestMethod]
1111
public void GetBytesForString()
1212
{
13-
AssertLoop("abc"u8.ToArray(), Library.GetBytes("abc"));
14-
AssertLoop(BitConverter.GetBytes('a'), Library.GetBytes('a'));
15-
AssertLoop(BitConverter.GetBytes(5L), Library.GetBytes(5L));
16-
AssertLoop(BitConverter.GetBytes(true), Library.GetBytes(true));
13+
AssertLoop("abc"u8.ToArray(), Library.GetBytes("abc")!);
14+
AssertLoop(BitConverter.GetBytes('a'), Library.GetBytes('a')!);
15+
AssertLoop(BitConverter.GetBytes(5L), Library.GetBytes(5L)!);
16+
AssertLoop(BitConverter.GetBytes(true), Library.GetBytes(true)!);
1717

18-
AssertLoop(decimal.GetBits(5m).SelectMany(f => BitConverter.GetBytes(f)).ToArray(), Library.GetBytes(5m));
18+
AssertLoop(decimal.GetBits(5m).SelectMany(f => BitConverter.GetBytes(f)).ToArray(), Library.GetBytes(5m)!);
1919
}
2020

2121
private void AssertLoop(byte[] byte1, byte[] byte2)

‎Musoq.Plugins.Tests/CountTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public void CountStringTest()
5858
Library.SetCount(Group, "test", "1");
5959
Library.SetCount(Group, "test", "4");
6060
Library.SetCount(Group, "test", "5");
61-
Library.SetCount(Group, "test", (string)null);
61+
Library.SetCount(Group, "test", (string?)null);
6262

6363
Assert.AreEqual(3, Library.Count(Group, "test"));
6464
}
@@ -69,7 +69,7 @@ public void CountStringParentTest()
6969
Library.SetCount(Group, "test", "1", 1);
7070
Library.SetCount(Group, "test", "4", 1);
7171
Library.SetCount(Group, "test", "6");
72-
Library.SetCount(Group, "test", (string)null, 1);
72+
Library.SetCount(Group, "test", (string?)null, 1);
7373

7474
Assert.AreEqual(2, Library.Count(Group, "test", 1));
7575
Assert.AreEqual(1, Library.Count(Group, "test"));

‎Musoq.Plugins.Tests/HashFunctionsTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public void Md5Test()
1414
[TestMethod]
1515
public void Md5NullTest()
1616
{
17-
Assert.AreEqual(null, Library.Md5((string)null));
17+
Assert.AreEqual((string?)null, Library.Md5((string?)null));
1818
}
1919

2020
[TestMethod]
@@ -26,7 +26,7 @@ public void Sha1Test()
2626
[TestMethod]
2727
public void Sha1NullTest()
2828
{
29-
Assert.AreEqual(null, Library.Sha1((string)null));
29+
Assert.AreEqual((string?)null, Library.Sha1((string?)null));
3030
}
3131

3232
[TestMethod]
@@ -38,7 +38,7 @@ public void Sha256Test()
3838
[TestMethod]
3939
public void Sha256NullTest()
4040
{
41-
Assert.AreEqual(null, Library.Sha256((string)null));
41+
Assert.AreEqual((string?)null, Library.Sha256((string?)null));
4242
}
4343

4444
[TestMethod]
@@ -50,6 +50,6 @@ public void Sha512Test()
5050
[TestMethod]
5151
public void Sha512NullTest()
5252
{
53-
Assert.AreEqual(null, Library.Sha512((string)null));
53+
Assert.AreEqual((string?)null, Library.Sha512((string?)null));
5454
}
5555
}

‎Musoq.Plugins.Tests/LibraryBaseBaseTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ namespace Musoq.Plugins.Tests;
77
public class LibraryBaseBaseTests
88
{
99
private class EmptyLibrary : LibraryBase { }
10-
private Group _root;
10+
private Group _root = null!;
1111

12-
protected LibraryBase Library;
13-
protected Group Group;
12+
protected LibraryBase Library = null!;
13+
protected Group Group = null!;
1414

1515
[TestInitialize]
1616
public void Initialize()

‎Musoq.Plugins.Tests/StringsTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ public void SubstrTest()
1616
Assert.AreEqual(string.Empty, Library.Substring("lorem ipsum dolor", 0));
1717
Assert.AreEqual("lorem", Library.Substring("lorem ipsum dolor", 5));
1818
Assert.AreEqual("lorem ipsum dolor", Library.Substring("lorem ipsum dolor", 150));
19-
Assert.AreEqual(null, Library.Substring(null, 150));
19+
Assert.AreEqual((string?)null, Library.Substring((string?)null, 150));
2020
}
2121

2222
[TestMethod]
2323
public void ConcatTest()
2424
{
2525
Assert.AreEqual("lorem ipsum dolor", Library.Concat("lorem ", "ipsum ", "dolor"));
26-
Assert.AreEqual("lorem dolor", Library.Concat("lorem ", null, "dolor"));
26+
Assert.AreEqual("lorem dolor", Library.Concat("lorem ", (string?)null, "dolor"));
2727
Assert.AreEqual("this is 1", Library.Concat("this ", "is ", 1));
2828
}
2929

‎Musoq.Plugins/Musoq.Plugins.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<Authors>Jakub Puchała</Authors>
88
<Product>Musoq</Product>
99
<PackageProjectUrl>https://github.com/Puchaczov/Musoq</PackageProjectUrl>
10-
<PackageLicenseUrl>https://github.com/Puchaczov/Musoq/blob/master/LICENSE</PackageLicenseUrl>
10+
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1111
<PackageTags>sql, dotnet-core</PackageTags>
1212
<PublishRepositoryUrl>true</PublishRepositoryUrl>
1313
<IncludeSymbols>true</IncludeSymbols>

0 commit comments

Comments
 (0)