update

Author: saadshams

README.md

@@ -11,36 +11,64 @@ PureMVC is a lightweight framework for creating applications based upon the clas
 ```commandline
 pip install PureMVC
 ```
-<!---
-Documentation: Update version docs/source/conf.py
-Update: python3 -m pip install --upgrade pip
-Development: pip install -e .
-Type Testing: 
-  pip install mypy
-  mypy ./src
-Testing: pytest test/
-Build: python -m build
-Publish: twine upload dist/*
-
-Documentation: 
-Install: pip install sphinx sphinx_rtd_theme
-Generate: 
-mkdir docs && cd docs && sphinx-quickstart --sep -p PureMVC -a "Saad Shams" -v "2.0.0" -r "BSD 3-Clause License" -l "en"
-cd ../ && sphinx-apidoc -o docs/source src/puremvc && cd docs && make html && cd .. && open docs/build/html/index.html
-
-Update
-sphinx-apidoc -o docs/source src/puremvc --force && cd docs && make html && cd .. && open docs/build/html/index.html
-
-conf.py
-import os
-import sys
-sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..', '..', 'src')))
-extensions = ['sphinx.ext.autodoc']
-html_theme = 'sphinx_rtd_theme'
-
-index.rst
-13: modules
--->
+---
+
+## Development
+
+### Install Dependency (Editable Package)
+```shell
+pip install -e .
+```
+
+### Type Checking
+```shell
+pip install mypy
+mypy ./src
+```
+
+### Testing
+```shell
+pytest test/
+```
+
+### Build & Publish
+```shell
+python -m build
+twine upload dist/*
+```
+
+### Generate Documentation with Sphinx
+- Install Sphinx and theme:
+  ```shell
+  pip install sphinx sphinx_rtd_theme
+  ```
+- Initialize Docs
+  ```shell
+  mkdir docs && cd docs 
+  sphinx-quickstart --sep -p PureMVC -a "Saad Shams" -v "2.0" -r "2.0.0" -l "en"
+  ```
+- Generate API docs and build HTML:
+  ```shell
+  cd ../ && sphinx-apidoc -o docs/source src/puremvc && cd docs && make html && cd .. && open docs/build/html/index.html
+  ```
+
+- To update docs after code changes:
+  ```shell
+  sphinx-apidoc -o docs/source src/puremvc --force && cd docs && make html && cd .. && open docs/build/html/index.html
+  ```
+- Snippet: conf.py
+  ```python
+  import os
+  import sys
+  sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..', '..', 'src')))
+  extensions = ['sphinx.ext.autodoc']
+  html_theme = 'sphinx_rtd_theme'
+  ```
+- Snippet: index.rst
+  ```
+  13: modules
+  ```
+---
 
 ## Status
 Production - [Version 2.0.2](https://github.com/PureMVC/puremvc-python-multicore-framework/blob/master/VERSION)

src/puremvc/core/View.py

@@ -120,16 +120,16 @@ def notify_observers(self, notification: INotification) -> None:
         :type notification: INotification
         :return: None
         """
-        # Get a reference to the observers list for this notification name
+        # Get a reference to the observer list for this notification name
         with self.observerMapLock:
             observers = self.observerMap.get(notification.name)
 
-        if observers:
-            # Copy observers (observers[:]) from reference array to working array,
-            # since the reference array may change during the notification loo
-            for observer in observers[:]:
-                # Notify Observers from the working array
-                observer.notify_observer(notification)
+        # Copy observers (observers[:]) from reference array to a working array,
+        # since the reference array may change during the notification loo
+        # Safe iteration, create a shallow copy of observers or use an empty list if observers is None or falsy.
+        for observer in list(observers or []):
+            # Notify Observers from the working array
+            observer.notify_observer(notification)
 
     def remove_observer(self, notification_name: str, notify_context: Any) -> None:
         """
@@ -172,18 +172,19 @@ def register_mediator(self, mediator: IMediator) -> None:
         :return: None
         """
         # Do not allow re-registration (you must to removeMediator first)
-        with self.mediatorMapLock:
-            if self.mediatorMap.get(mediator.mediator_name):
-                return
+        if self.has_mediator(mediator.mediator_name):
+            return
+
+        mediator.initialize_notifier(self.multitonKey)
 
-            mediator.initialize_notifier(self.multitonKey)
+        with self.mediatorMapLock:
             self.mediatorMap[mediator.mediator_name] = mediator
 
+        observer = Observer(mediator.handle_notification, mediator)
+
         interests = mediator.list_notification_interests()
-        if interests:
-            observer = Observer(mediator.handle_notification, mediator)
-            for interest in interests:
-                self.register_observer(interest, observer)
+        for interest in interests:
+            self.register_observer(interest, observer)
 
         mediator.on_register()
 
@@ -222,11 +223,12 @@ def remove_mediator(self, mediator_name: str) -> Optional[IMediator]:
         """
         with self.mediatorMapLock:
             mediator = self.mediatorMap.get(mediator_name)
-            if not mediator: return None
-            for interest in mediator.list_notification_interests():
-                self.remove_observer(interest, mediator)
 
-            del self.mediatorMap[mediator_name]
+        if not mediator: return None
+        for interest in mediator.list_notification_interests():
+            self.remove_observer(interest, mediator)
+
+        del self.mediatorMap[mediator_name]
 
         mediator.on_remove()
         return mediator