Issue between Black 26.3.1 and isort 8.0.1?

[mig5]

@DanielNoord I've just been looking at this 2023 issue which I saw you very recently commented on #2116, which I thought might be a clue to the issue I am seeing: I am currently fighting between black 26.3.1 and isort 8.0.1. Black seems to insist on adding removing a newline and isort removes adds it right after (in my pre-commit routine).

I note these commits in a recent PR:

bcdbc56
f12e0a2

Is Copilot downgrading black for the same reason (without realizing it)?

Wondering if there needs to be a specific flag for isort to work with the latest black?

[DanielNoord]

Hey @mig5!

The commit you reference is Copilot responding to a completely unrelated security "vulnerability" in a PR where it shouldn't.
I see black 26.3.1 was released 19 hours ago, so that could explain why we haven't had a report about this. At the same time, we were able to upgrade without any issues ourselves, see #2489.

Do you have a PR I can look at? Would also be interesting to know what you isort config is.

[mig5]

Sorry @DanielNoord for the misunderstanding.

Unfortunately my PR is in a private repo, but here is the .pre-commit-config.yaml:

---
default_install_hook_types: [pre-commit, post-merge]

repos:
  - repo: local
    hooks:
      - id: end-of-file-fixer
        name: Enforce end of file format
        entry: end-of-file-fixer
        language: system
        types: [text]
        exclude: "\\.j2$"

      - id: trailing-whitespace-fixer
        name: Enforce removal of trailing whitespace
        entry: trailing-whitespace-fixer
        language: system
        types: [text]

      - id: black
        name: Enforce black formatting for python
        entry: black
        language: system
        types: [python]

      - id: blacken-docs
        name: Enforce black formatting for python documentation
        entry: blacken-docs
        language: system
        types: [text]

      - id: reorder-python-imports
        name: Enforce import ordering for python
        entry: isort
        args:
          - --filter-files
        language: system
        require_serial: true
        types: [python]

What we were seeing in our action:

Enforce black formatting for python......................................Failed
- hook id: black
- files were modified by this hook

reformatted lookup_plugins/foo.py

All done! ✨ 🍰 ✨
1 file reformatted, 2 files left unchanged.

Enforce black formatting for python documentation........................Passed
Enforce import ordering for python.......................................Failed
- hook id: reorder-python-imports
- files were modified by this hook

Fixing /home/user/git/infrastructure/lookup_plugins/foo.py

When we ran black on the file, it would remove a line:

 from ansible.plugins.lookup import LookupBase
 
-
 NET_LIST = "https://www.cloudflare.com/ips-v4"

then isort seems to want to add it back:

@@ -14,6 +14,7 @@ import requests
 from ansible.errors import AnsibleParserError
 from ansible.plugins.lookup import LookupBase
 
+
 NET_LIST = "https://www.cloudflare.com/ips-v4"

This issue has begun for us with the jump from Black 24.10.0 to 26.3.1.

We were on isort 7.0.0, we tried upgrading to 8.0.1 but the problem continued.

[DanielNoord]

Could you be running into this issue: #2452?

[mig5]

That was it! Thanks and sorry for the duplicate. My isort configuration was in the pyproject.toml and I had forgotten that (and indeed, lines_after_import = 2 was there).

Thanks again.