Skip to content

Commit 490b595

Browse files
authored
Merge pull request #21869 from krzysztof-cabaj/pkg_lwip_ipv4_dependencies_v2
pkg/lwip: fix dependencies when LWIP IPv4 and LWIP_DHCP is used
2 parents ff7a266 + 6be2534 commit 490b595

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

pkg/lwip/Makefile.dep

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,17 @@ endif
111111

112112
# Addition of missing modules for boards that do not have physical network
113113
# module - a dirty hack when lwip_dhcp is used for IPv4 (use of lwip_ipv4 module)
114-
# on such boards (lack of netdev_new_api module)
114+
# on such boards (lack of netdev_eth module)
115+
#
116+
# This is dirty-hack" to solve compilation problem
117+
# TODO:
118+
# Find the root cause of the problem. PR #17174 and PR #17162 could be a good
119+
# starting point.
115120
ifneq (,$(filter lwip_dhcp,$(USEMODULE)))
116121
ifneq (,$(filter lwip_ipv4,$(USEMODULE)))
117-
ifeq (,$(filter netdev_new_api,$(USEMODULE)))
122+
ifeq (,$(filter netdev_eth,$(USEMODULE)))
118123
USEMODULE += netdev_eth
119-
USEMODULE += netdev_new_api
120-
endif
124+
endif
121125
endif
122126
endif
123127

0 commit comments

Comments
 (0)