change flag name to allowAllAgentsAccess, to be more accurate

Author: sunhmy-amd

projects/clr/rocclr/device/rocm/rocdevice.cpp

@@ -2035,7 +2035,7 @@ hsa_amd_memory_pool_t Device::getHostMemoryPool(MemorySegment mem_seg,
 
 // ================================================================================================
 void* Device::hostAlloc(size_t size, size_t alignment, MemorySegment mem_seg,
-                        const void* agentInfo, bool allowAccess) const {
+                        const void* agentInfo, bool allowAllAgentsAccess) const {
   void* ptr = nullptr;
   uint32_t memFlags = 0;
   if (mem_seg == kKernArg) {
@@ -2055,17 +2055,13 @@ void* Device::hostAlloc(size_t size, size_t alignment, MemorySegment mem_seg,
     return nullptr;
   }
 
-  if (allowAccess) {
+  // Allow access to all GPU agents if the flag is set
+  // otherwise only allow access to the local backend device.
+  if (allowAllAgentsAccess) {
     stat = Hsa::agents_allow_access(gpu_agents_.size(), &gpu_agents_[0], nullptr, ptr);
-  } else {
-    hsa_amd_memory_pool_access_t access;
-    stat = Hsa::agent_memory_pool_get_info(bkendDevice_, pool,
-                                           HSA_AMD_AGENT_MEMORY_POOL_INFO_ACCESS, &access);
-                                           
-    if ((stat == HSA_STATUS_SUCCESS) && (access == HSA_AMD_MEMORY_POOL_ACCESS_DISALLOWED_BY_DEFAULT))
-    {
-      stat = Hsa::agents_allow_access(1, &bkendDevice_, nullptr, ptr);
-    }
+  }
+  else {
+    stat = Hsa::agents_allow_access(1, &bkendDevice_, nullptr, ptr);
   }
 
   if (stat != HSA_STATUS_SUCCESS) {
@@ -2200,7 +2196,7 @@ void Device::releaseMemory(void* ptr, size_t size) const {
   }
 }
 
-void* Device::deviceLocalAlloc(size_t size, const AllocationFlags& flags, bool allowAccess) const {
+void* Device::deviceLocalAlloc(size_t size, const AllocationFlags& flags, bool allowAllAgentsAccess) const {
   const hsa_amd_memory_pool_t& pool =
       (flags.pseudo_fine_grain_ && gpu_ext_fine_grained_segment_.handle)
           ? gpu_ext_fine_grained_segment_
@@ -2235,7 +2231,7 @@ void* Device::deviceLocalAlloc(size_t size, const AllocationFlags& flags, bool a
     return nullptr;
   }
 
-  if (allowAccess) {
+  if (allowAllAgentsAccess) {
     if (isP2pEnabled() && deviceAllowAccess(ptr) == false) {
       LogError("Allow p2p access for memory allocation");
       memFree(ptr, size);

projects/clr/rocclr/device/rocm/rocdevice.hpp

@@ -429,7 +429,7 @@ class Device : public NullDevice {
   virtual bool globalFreeMemory(size_t* freeMemory) const override;
   virtual void* hostAlloc(size_t size, size_t alignment,
                           MemorySegment mem_seg = MemorySegment::kNoAtomics,
-                          const void* agentInfo = nullptr, bool allowAccess = true) const override;  // nullptr uses default CPU agent
+                          const void* agentInfo = nullptr, bool allowAllAgentsAccess = true) const override;  // nullptr uses default CPU agent
   virtual void hostFree(void* ptr, size_t size = 0) const override;
 
   virtual bool amdFileRead(amd::Os::FileDesc handle, void* devicePtr, uint64_t size, int64_t file_offset,
@@ -444,7 +444,7 @@ class Device : public NullDevice {
   uint64_t deviceVmemAlloc(size_t size, uint64_t flags) const;
 
   void* deviceLocalAlloc(size_t size,
-                        const AllocationFlags& flags = AllocationFlags{}, bool allowAccess = true) const override;
+                        const AllocationFlags& flags = AllocationFlags{}, bool allowAllAgentsAccess = true) const override;
   void* reserveMemory(size_t size, size_t alignment) const;
   void releaseMemory(void* ptr, size_t size) const;
   void memFree(void* ptr, size_t size) const;