Skip to content

Commit b7edb48

Browse files
committed
Don't suggest use of NULL serializer
It's better to rely on explicit serializer for data and metadata. So that we pass string values in a flat hash to sidekiq. Thus we suggest RubyEventStore::Serializers::YAML or simply JSON as a serializer, so 3rd party (sidekiq) won't decide on how to handle serialization/deserialization. There's an added benefit of doing so: serialization/deserialization would occur just once when using the same serializer for both scheduler and repository.
1 parent ce4f16e commit b7edb48

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

contrib/ruby_event_store-sidekiq_scheduler/spec/sidekiq_scheduler_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module RubyEventStore
88
before(:each) { MyAsyncHandler.reset }
99

1010
it_behaves_like :scheduler, SidekiqScheduler.new(serializer: RubyEventStore::Serializers::YAML)
11-
it_behaves_like :scheduler, SidekiqScheduler.new(serializer: RubyEventStore::NULL)
11+
it_behaves_like :scheduler, SidekiqScheduler.new(serializer: JSON)
1212

1313
let(:event) do
1414
TimeEnrichment.with(Event.new(event_id: "83c3187f-84f6-4da7-8206-73af5aca7cc8"), timestamp: Time.utc(2019, 9, 30))
@@ -18,27 +18,27 @@ module RubyEventStore
1818

1919
describe "#verify" do
2020
specify do
21-
scheduler = SidekiqScheduler.new(serializer: RubyEventStore::NULL)
21+
scheduler = SidekiqScheduler.new(serializer: JSON)
2222
proper_handler = Class.new { include Sidekiq::Worker }
2323

2424
expect(scheduler.verify(proper_handler)).to eq(true)
2525
end
2626

2727
specify do
28-
scheduler = SidekiqScheduler.new(serializer: RubyEventStore::NULL)
28+
scheduler = SidekiqScheduler.new(serializer: JSON)
2929
some_class = Class.new
3030

3131
expect(scheduler.verify(some_class)).to eq(false)
3232
end
3333

3434
specify do
35-
scheduler = SidekiqScheduler.new(serializer: RubyEventStore::NULL)
35+
scheduler = SidekiqScheduler.new(serializer: JSON)
3636

3737
expect(scheduler.verify(Sidekiq::Worker)).to eq(false)
3838
end
3939

4040
specify do
41-
scheduler = SidekiqScheduler.new(serializer: RubyEventStore::NULL)
41+
scheduler = SidekiqScheduler.new(serializer: JSON)
4242
expect(scheduler.verify(Object.new)).to eq(false)
4343
end
4444
end

0 commit comments

Comments
 (0)