Commit b7edb48
committed
Don't suggest use of NULL serializer
It's better to rely on explicit serializer for data and metadata.
So that we pass string values in a flat hash to sidekiq.
Thus we suggest RubyEventStore::Serializers::YAML or simply JSON as
a serializer, so 3rd party (sidekiq) won't decide on how to handle
serialization/deserialization.
There's an added benefit of doing so: serialization/deserialization
would occur just once when using the same serializer for both scheduler
and repository.1 parent ce4f16e commit b7edb48
File tree
1 file changed
+5
-5
lines changed- contrib/ruby_event_store-sidekiq_scheduler/spec
1 file changed
+5
-5
lines changedLines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
0 commit comments