Commit b689047
committed
fused_group / group: rename CD_INSERT caller's 'val' to 'row_val'
The CD_INSERT macro at src/ops/group.c:1038 defines an internal
'int64_t val = (VAL_EXPR);' from its argument. The has-nulls
fallback loop earlier in the same function declared its own
'int64_t val' in the outer scope and then called CD_INSERT(val).
After macro expansion that became 'int64_t val = (val);' — clang
on macOS flags it as -Werror,-Wuninitialized. gcc didn't notice.
Renaming the outer variable to row_val avoids the shadowing. Only
the fallback callsite needed the rename; the fast-path loops were
already passing distinct expressions (d[r], v, etc.).
Caught with a local CC=clang build matching CI's compiler. Last
build error this commit fixes; clang release build is now clean
and the test matrix is 2335 / 2336 passing, 0 failed.1 parent 1655609 commit b689047
1 file changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1111 | 1111 | | |
1112 | 1112 | | |
1113 | 1113 | | |
1114 | | - | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
1115 | 1118 | | |
1116 | 1119 | | |
1117 | 1120 | | |
1118 | 1121 | | |
1119 | | - | |
| 1122 | + | |
1120 | 1123 | | |
1121 | | - | |
| 1124 | + | |
1122 | 1125 | | |
1123 | | - | |
| 1126 | + | |
1124 | 1127 | | |
1125 | 1128 | | |
1126 | 1129 | | |
| |||
0 commit comments