Improved Plane Detection (#406)

* chore: add vertices and plane classification

* feat: get plane classification working

* chore: remove debug logs

* chore: 16kb page size support

* fix: building issues

* feat: update viroarplaneselector with newest features

Author: doranteseduardo

android/react_viro/react_viro-release.aar

@@ -3,7 +3,15 @@ pluginManagement {
     includeBuild("../node_modules/expo-modules-core/expo-module-gradle-plugin")
 }
 plugins { id("com.facebook.react.settings") }
-extensions.configure(com.facebook.react.ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand() }
+extensions.configure(com.facebook.react.ReactSettingsExtension){ ex ->
+    // Use a config file outside the build directory to avoid it being cleaned
+    def autolinkConfigFile = new File(rootDir, ".gradle/autolinking.json")
+    if (autolinkConfigFile.exists()) {
+        ex.autolinkLibrariesFromConfigFile(autolinkConfigFile)
+    } else {
+        ex.autolinkLibrariesFromCommand()
+    }
+}
 includeBuild("../node_modules/@react-native/gradle-plugin")
 includeBuild("../node_modules/expo-modules-core/expo-module-gradle-plugin")
 include ':gvr_common', ':viro_bridge', ':viro_renderer', ':arcore_client'

android/settings.gradle

@@ -71,6 +71,37 @@ android {
     */
 }
 
+react {
+    // Configure node executable with full path to avoid PATH issues
+    def nodeExec = project.hasProperty('nodeExecutable') ? project.property('nodeExecutable') : null
+    if (nodeExec != null && !nodeExec.isEmpty()) {
+        nodeExecutableAndArgs.set([nodeExec])
+    } else {
+        // Try to find node in common locations as fallback
+        def nodePath = ["/usr/local/bin/node", "/usr/bin/node",
+                        System.getProperty("user.home") + "/.local/share/fnm/node-versions/v20.19.5/installation/bin/node"]
+                        .find { new File(it).exists() }
+        if (nodePath != null) {
+            nodeExecutableAndArgs.set([nodePath])
+        }
+    }
+}
+
+// Also configure the tasks directly to ensure the setting is applied
+// This is necessary because the React plugin creates tasks before the react {} block is evaluated
+afterEvaluate {
+    def nodeExec = project.hasProperty('nodeExecutable') ? project.property('nodeExecutable') : null
+    if (nodeExec != null && !nodeExec.isEmpty()) {
+        // Configure all React Native codegen tasks with the full path to node
+        tasks.withType(com.facebook.react.tasks.GenerateCodegenSchemaTask).configureEach {
+            nodeExecutableAndArgs.set([nodeExec])
+        }
+        tasks.withType(com.facebook.react.tasks.GenerateCodegenArtifactsTask).configureEach {
+            nodeExecutableAndArgs.set([nodeExec])
+        }
+    }
+}
+
 dependencies {
     androidTestImplementation('androidx.test.espresso:espresso-core:3.1.0', {
         exclude group: 'com.android.support', module: 'support-annotations'

android/viro_bridge/build.gradle

@@ -128,15 +128,30 @@ public void removeARNode(ARDeclarativeNode node) {
     }
 
     public void setAnchorDetectionTypes(ReadableArray types) {
+        // DEBUG LOGGING - START
+        android.util.Log.d("ViroAR", "=== setAnchorDetectionTypes called ===");
+        if (types != null) {
+            for (int i = 0; i < types.size(); i++) {
+                android.util.Log.d("ViroAR", "  Prop value[" + i + "]: " + types.getString(i));
+            }
+        } else {
+            android.util.Log.d("ViroAR", "  types is NULL!");
+        }
+        // DEBUG LOGGING - END
+
         EnumSet<ViroViewARCore.AnchorDetectionType> typesList = EnumSet.noneOf(ViroViewARCore.AnchorDetectionType.class);
         if (types != null) {
             for (int i = 0; i < types.size(); i++) {
                 ViroViewARCore.AnchorDetectionType type = ViroViewARCore.AnchorDetectionType.valueFromString(types.getString(i));
                 if (type != null) {
+                    android.util.Log.d("ViroAR", "  Parsed type: " + type);
                     typesList.add(type);
+                } else {
+                    android.util.Log.e("ViroAR", "  FAILED to parse: " + types.getString(i));
                 }
             }
         }
+        android.util.Log.d("ViroAR", "  Final typesList size: " + typesList.size());
         ((ARScene) mNativeScene).setAnchorDetectionTypes(typesList);
     }
 
@@ -152,6 +167,9 @@ public void setCanARPointCloudUpdate(boolean canARPointCloudUpdate) {
 
     @Override
     public void onTrackingUpdated(ARScene.TrackingState state, ARScene.TrackingStateReason reason) {
+        // DEBUG LOGGING
+        android.util.Log.d("ViroAR", "📍 Tracking updated: state=" + state + " (" + state.getId() + "), reason=" + reason + " (" + reason.getId() + ")");
+
         WritableMap returnMap = Arguments.createMap();
         returnMap.putInt("state", state.getId());
         returnMap.putInt("reason", reason.getId());

android/viro_bridge/src/main/java/com/viromedia/bridge/component/node/VRTARScene.java

@@ -48,6 +48,7 @@ public static WritableMap mapFromARAnchor(ARAnchor anchor) {
             returnMap.putDouble("width", plane.getExtent().x);
             returnMap.putDouble("height", plane.getExtent().z);
             returnMap.putString("alignment", plane.getAlignment().getStringValue());
+            returnMap.putString("classification", plane.getClassification().getStringValue());
 
             WritableArray polygonPointsArray = Arguments.createArray();
             for (Vector point : plane.getVertices()){