Make Store.filter internal (#1882)

* Make Store.filter internal

We're seeing that `@_spi` can still come up in autocomplete. Now Xcode
surfaces internal stuff too occasionally, but maybe this will suppress
it a bit.

* wip

* fix

(cherry picked from commit b690a617d1366bd36f047e5da5d3185f20daac71)

Author: stephencelis

Sources/ComposableArchitecture/Store.swift

@@ -334,7 +334,7 @@ public final class Store<State, Action> {
     self.scope(state: toChildState, action: { $0 })
   }
 
-  @_spi(Internals) public func filter(
+  func filter(
     _ isSent: @escaping (State, Action) -> Bool
   ) -> Store<State, Action> {
     self.threadCheck(status: .scope)

Tests/ComposableArchitectureTests/StoreFilterTests.swift

@@ -0,0 +1,28 @@
+#if DEBUG
+  import Combine
+  import XCTest
+
+  @testable import ComposableArchitecture
+
+  @MainActor
+  final class StoreFilterTests: XCTestCase {
+    var cancellables: Set<AnyCancellable> = []
+
+    func testFilter() {
+      let store = Store<Int?, Void>(initialState: nil, reducer: EmptyReducer())
+        .filter { state, _ in state != nil }
+
+      let viewStore = ViewStore(store)
+      var count = 0
+      viewStore.publisher
+        .sink { _ in count += 1 }
+        .store(in: &self.cancellables)
+
+      XCTAssertEqual(count, 1)
+      viewStore.send(())
+      XCTAssertEqual(count, 1)
+      viewStore.send(())
+      XCTAssertEqual(count, 1)
+    }
+  }
+#endif

Tests/ComposableArchitectureTests/StoreTests.swift

@@ -588,22 +588,5 @@ final class StoreTests: XCTestCase {
 
     XCTAssertEqual(viewStore.state, UUID(uuidString: "deadbeef-dead-beef-dead-beefdeadbeef")!)
   }
-
-  func testFilter() {
-    let store = Store<Int?, Void>(initialState: nil, reducer: EmptyReducer())
-      .filter { state, _ in state != nil }
-
-    let viewStore = ViewStore(store)
-    var count = 0
-    viewStore.publisher
-      .sink { _ in count += 1 }
-      .store(in: &self.cancellables)
-
-    XCTAssertEqual(count, 1)
-    viewStore.send(())
-    XCTAssertEqual(count, 1)
-    viewStore.send(())
-    XCTAssertEqual(count, 1)
-  }
 }
 #endif