refactor: resolve activity redesign (MetaMask#35203)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

Resolves `tmcuActivityRedesignEnabled` and
`tmcuTransactionsRedesignEnabled`.

Legacy-only selectors, components, fixtures, tests, and non-production
and unused implementation are removed.

**NOTE:** This PR focuses on removing *unused* code, the pre-redesign
Activity flow, including *assertions on unused code*. _New_ assertions
will be a separate PR.


## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: TMCU-854, TMCU-864

## **Manual testing steps**

```gherkin
Feature: Activity redesign is the default experience

  Scenario: user views activity and transaction details
    Given a wallet with EVM and non-EVM activity, including bridge, Ramp, Perps, and Predict entries
    When the user opens Activity and selects supported activity rows
    Then the redesigned Activity list and Activity Details screens are shown
    And Ramp sell and created-deposit actions retain their specialized destinations
```

## **Screenshots/Recordings**

N/A — this removes inactive legacy code while preserving the
already-launched redesign UI.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [x] I've tested on Android — N/A; no rendering behavior was added or
changed
- [x] I've tested with a power user scenario — N/A; no rendering
behavior was added or changed
- [x] I've instrumented key operations with Sentry traces for production
performance metrics — N/A; no new operation was introduced

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-756b7456-0030-40d4-9d9a-76e917a85f51?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-756b7456-0030-40d4-9d9a-76e917a85f51&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: n3ps

app/components/UI/Bridge/components/TransactionDetails/TransactionDetails.test.tsx

@@ -28,7 +28,6 @@ import { TabEmptyState } from '../../../../../component-library/components-temp/
 import ButtonFilter from '../../../../../component-library/components-temp/ButtonFilter';
 import { selectSelectedAccountGroupEvmInternalAccount } from '../../../../../selectors/multichainAccounts/accountTreeController';
 import { selectChainId } from '../../../../../selectors/networkController';
-import { selectIsTransactionsRedesignEnabled } from '../../../../../selectors/featureFlagController/activityRedesign';
 import {
   formatAccountToCaipAccountId,
   PERPS_TRANSACTIONS_HISTORY_CONSTANTS,
@@ -80,9 +79,6 @@ const PerpsTransactionsView: React.FC = () => {
   const evmAccount = useSelector(selectSelectedAccountGroupEvmInternalAccount);
   const selectedAddress = evmAccount?.address;
   const currentChainId = useSelector(selectChainId);
-  const isTransactionsRedesignEnabled = useSelector(
-    selectIsTransactionsRedesignEnabled,
-  );
   const isTestnet = usePerpsNetwork() === 'testnet';
   const accountId = useMemo(() => {
     if (!selectedAddress || !currentChainId) {
@@ -335,12 +331,7 @@ const PerpsTransactionsView: React.FC = () => {
         .build(),
     );
 
-    navigateToPerpsTransactionDetails(
-      navigation,
-      transaction,
-      isTransactionsRedesignEnabled,
-      isTestnet,
-    );
+    navigateToPerpsTransactionDetails(navigation, transaction, isTestnet);
   };
 
   // Render right content based on transaction type

app/components/UI/Bridge/components/TransactionDetails/TransactionDetails.tsx

@@ -414,29 +414,6 @@ describe('PerpsMarketTradesList', () => {
         }),
       );
     });
-
-    it('navigates to the legacy position screen when redesign is disabled', () => {
-      const { useSelector } = jest.requireMock('react-redux');
-      useSelector.mockImplementation(() => false);
-      mockUsePerpsMarketFills.mockReturnValue(
-        createMockFillsReturn(mockOrderFills),
-      );
-
-      render(<PerpsMarketTradesList symbol="ETH" />);
-
-      const tradeItem = screen.getByText('Opened long');
-      fireEvent.press(tradeItem.parent?.parent || tradeItem);
-
-      expect(mockNavigate).toHaveBeenCalledWith(
-        Routes.PERPS.POSITION_TRANSACTION,
-        expect.objectContaining({
-          transaction: expect.objectContaining({
-            type: 'trade',
-            id: expect.stringContaining('fill-1'),
-          }),
-        }),
-      );
-    });
   });
 
   describe('Hook Integration', () => {

app/components/UI/Perps/Views/PerpsTransactionsView/PerpsTransactionsView.tsx

@@ -1,7 +1,6 @@
 import React, { useCallback, useMemo } from 'react';
 import { View, TouchableOpacity, FlatList } from 'react-native';
 import { useNavigation } from '@react-navigation/native';
-import { useSelector } from 'react-redux';
 import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 
 import {
@@ -38,7 +37,6 @@ import {
   HOME_SCREEN_CONFIG,
 } from '../../constants/perpsConfig';
 import { navigateToPerpsTransactionDetails } from '../../utils/navigateToPerpsTransactionDetails';
-import { selectIsTransactionsRedesignEnabled } from '../../../../../selectors/featureFlagController/activityRedesign';
 import { usePerpsNetwork } from '../../hooks/usePerpsNetwork';
 
 interface PerpsMarketTradesListProps {
@@ -52,9 +50,6 @@ const PerpsMarketTradesList: React.FC<PerpsMarketTradesListProps> = ({
 }) => {
   const { styles } = useStyles(styleSheet, {});
   const navigation = useNavigation<AppNavigationProp>();
-  const isTransactionsRedesignEnabled = useSelector(
-    selectIsTransactionsRedesignEnabled,
-  );
   const isTestnet = usePerpsNetwork() === 'testnet';
   const { trackEvent, createEventBuilder } = useAnalytics();
 
@@ -96,20 +91,9 @@ const PerpsMarketTradesList: React.FC<PerpsMarketTradesListProps> = ({
           .build(),
       );
 
-      navigateToPerpsTransactionDetails(
-        navigation,
-        transaction,
-        isTransactionsRedesignEnabled,
-        isTestnet,
-      );
+      navigateToPerpsTransactionDetails(navigation, transaction, isTestnet);
     },
-    [
-      navigation,
-      isTransactionsRedesignEnabled,
-      isTestnet,
-      trackEvent,
-      createEventBuilder,
-    ],
+    [navigation, isTestnet, trackEvent, createEventBuilder],
   );
 
   // Render right content for trades

app/components/UI/Perps/components/PerpsMarketTradesList/PerpsMarketTradesList.test.tsx

@@ -346,21 +346,6 @@ describe('PerpsRecentActivityList', () => {
       );
     });
 
-    it('navigates to the legacy position screen when redesign is disabled', () => {
-      const { useSelector } = jest.requireMock('react-redux');
-      useSelector.mockImplementation(() => false);
-
-      render(<PerpsRecentActivityList transactions={mockTransactions} />);
-
-      const transactionItem = screen.getByText('Opened long');
-      fireEvent.press(transactionItem.parent?.parent || transactionItem);
-
-      expect(mockNavigate).toHaveBeenCalledWith(
-        Routes.PERPS.POSITION_TRANSACTION,
-        { transaction: mockTransactions[0] },
-      );
-    });
-
     it('handles multiple presses on header', () => {
       render(<PerpsRecentActivityList transactions={mockTransactions} />);
 

app/components/UI/Perps/components/PerpsMarketTradesList/PerpsMarketTradesList.tsx

@@ -1,7 +1,6 @@
 import React, { useCallback } from 'react';
 import { FlatList } from 'react-native';
 import { useNavigation } from '@react-navigation/native';
-import { useSelector } from 'react-redux';
 import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import {
   Box,
@@ -30,7 +29,6 @@ import {
   TransactionDetailLocation,
 } from '../../../../../core/Analytics/events/transactions';
 import { navigateToPerpsTransactionDetails } from '../../utils/navigateToPerpsTransactionDetails';
-import { selectIsTransactionsRedesignEnabled } from '../../../../../selectors/featureFlagController/activityRedesign';
 import { usePerpsNetwork } from '../../hooks/usePerpsNetwork';
 
 interface PerpsRecentActivityListProps {
@@ -45,9 +43,6 @@ const PerpsRecentActivityList: React.FC<PerpsRecentActivityListProps> = ({
   iconSize = HOME_SCREEN_CONFIG.DefaultIconSize,
 }) => {
   const navigation = useNavigation<AppNavigationProp>();
-  const isTransactionsRedesignEnabled = useSelector(
-    selectIsTransactionsRedesignEnabled,
-  );
   const isTestnet = usePerpsNetwork() === 'testnet';
   const { trackEvent, createEventBuilder } = useAnalytics();
   const activityTitle = strings('perps.home.recent_activity');
@@ -75,21 +70,10 @@ const PerpsRecentActivityList: React.FC<PerpsRecentActivityListProps> = ({
             .build(),
         );
 
-        navigateToPerpsTransactionDetails(
-          navigation,
-          transaction,
-          isTransactionsRedesignEnabled,
-          isTestnet,
-        );
+        navigateToPerpsTransactionDetails(navigation, transaction, isTestnet);
       }
     },
-    [
-      navigation,
-      isTransactionsRedesignEnabled,
-      isTestnet,
-      trackEvent,
-      createEventBuilder,
-    ],
+    [navigation, isTestnet, trackEvent, createEventBuilder],
   );
 
   const renderItem = useCallback(

app/components/UI/Perps/components/PerpsRecentActivityList/PerpsRecentActivityList.test.tsx

@@ -60,18 +60,8 @@ jest.mock('@metamask/design-system-react-native', () => ({
   },
 }));
 
-let mockTransactionsRedesignEnabled = false;
 let mockDepositMeta: { chainId: string } | undefined;
 
-jest.mock(
-  '../../../../selectors/featureFlagController/activityRedesign',
-  () => ({
-    selectIsTransactionsRedesignEnabled: jest.fn(
-      () => mockTransactionsRedesignEnabled,
-    ),
-  }),
-);
-
 jest.mock('../../../../selectors/transactionController', () => ({
   selectTransactionMetadataById: jest.fn(() => mockDepositMeta),
 }));
@@ -103,7 +93,6 @@ describe('usePerpsToasts', () => {
   beforeEach(() => {
     jest.clearAllMocks();
 
-    mockTransactionsRedesignEnabled = false;
     mockDepositMeta = undefined;
     mockShowToast = jest.fn();
     mockCloseToast = jest.fn();
@@ -219,7 +208,6 @@ describe('usePerpsToasts', () => {
       });
 
       it('tracks to the redesigned details screen when the redesign is enabled', () => {
-        mockTransactionsRedesignEnabled = true;
         mockDepositMeta = { chainId: '0xa4b1' };
         const { result } = renderHook(() => usePerpsToasts());
         const config =
@@ -242,8 +230,8 @@ describe('usePerpsToasts', () => {
         );
       });
 
-      it('tracks to the legacy details screen when the redesign is disabled', () => {
-        mockDepositMeta = { chainId: '0xa4b1' };
+      it('tracks to the legacy details screen when the deposit metadata has no chainId', () => {
+        mockDepositMeta = undefined;
         const { result } = renderHook(() => usePerpsToasts());
         const config =
           result.current.PerpsToastOptions.accountManagement.deposit.inProgress(

app/components/UI/Perps/components/PerpsRecentActivityList/PerpsRecentActivityList.tsx

@@ -29,7 +29,6 @@ import {
 } from '../../../../component-library/components/Toast/Toast.types';
 import Routes from '../../../../constants/navigation/Routes';
 import { navigateToTransactionDetails } from '../../../../util/navigation/navigateToTransactionDetails';
-import { selectIsTransactionsRedesignEnabled } from '../../../../selectors/featureFlagController/activityRedesign';
 import { selectTransactionMetadataById } from '../../../../selectors/transactionController';
 import { store } from '../../../../store';
 // eslint-disable-next-line import-x/no-restricted-paths -- TODO(ADR-0020): shared activity type-filter; route-isolation backlog
@@ -395,8 +394,6 @@ const usePerpsToasts = (): {
           transactionId,
           initialTypeFilter: ActivityTypeFilter.Perps,
           ...(perpsFilter ? { initialPerpsFilter: perpsFilter } : {}),
-          isTransactionsRedesignEnabled:
-            selectIsTransactionsRedesignEnabled(state),
           ...(depositMeta?.chainId
             ? { chainId: toEvmCaipChainId(depositMeta.chainId) }
             : {}),

app/components/UI/Perps/hooks/usePerpsToasts.test.tsx

@@ -51,12 +51,7 @@ describe('navigateToPerpsTransactionDetails', () => {
   it('opens Activity details for a mapped historic fill when redesign is enabled', () => {
     const navigation = createNavigation();
 
-    navigateToPerpsTransactionDetails(
-      navigation,
-      tradeTransaction,
-      true,
-      false,
-    );
+    navigateToPerpsTransactionDetails(navigation, tradeTransaction, false);
 
     expect(navigation.navigate).toHaveBeenCalledWith(
       Routes.ACTIVITY_DETAILS,
@@ -71,12 +66,7 @@ describe('navigateToPerpsTransactionDetails', () => {
   it('tags testnet deposits with Arbitrum Sepolia', () => {
     const navigation = createNavigation();
 
-    navigateToPerpsTransactionDetails(
-      navigation,
-      depositTransaction,
-      true,
-      true,
-    );
+    navigateToPerpsTransactionDetails(navigation, depositTransaction, true);
 
     expect(navigation.navigate).toHaveBeenCalledWith(
       Routes.ACTIVITY_DETAILS,
@@ -87,22 +77,6 @@ describe('navigateToPerpsTransactionDetails', () => {
     );
   });
 
-  it('opens the legacy position screen for a mapped fill when redesign is disabled', () => {
-    const navigation = createNavigation();
-
-    navigateToPerpsTransactionDetails(
-      navigation,
-      tradeTransaction,
-      false,
-      false,
-    );
-
-    expect(navigation.navigate).toHaveBeenCalledWith(
-      Routes.PERPS.POSITION_TRANSACTION,
-      { transaction: tradeTransaction },
-    );
-  });
-
   it('falls back to the legacy position screen when a trade cannot be mapped', () => {
     const navigation = createNavigation();
     const fill = tradeTransaction.fill;
@@ -117,7 +91,7 @@ describe('navigateToPerpsTransactionDetails', () => {
       },
     };
 
-    navigateToPerpsTransactionDetails(navigation, unmappedTrade, true, false);
+    navigateToPerpsTransactionDetails(navigation, unmappedTrade, false);
 
     expect(navigation.navigate).toHaveBeenCalledWith(
       Routes.PERPS.POSITION_TRANSACTION,
@@ -137,7 +111,7 @@ describe('navigateToPerpsTransactionDetails', () => {
       asset: 'ETH',
     };
 
-    navigateToPerpsTransactionDetails(navigation, unmappedOrder, true, false);
+    navigateToPerpsTransactionDetails(navigation, unmappedOrder, false);
 
     expect(navigation.navigate).toHaveBeenCalledWith(
       Routes.PERPS.ORDER_TRANSACTION,
@@ -157,7 +131,7 @@ describe('navigateToPerpsTransactionDetails', () => {
       asset: 'ETH',
     };
 
-    navigateToPerpsTransactionDetails(navigation, unmappedFunding, true, false);
+    navigateToPerpsTransactionDetails(navigation, unmappedFunding, false);
 
     expect(navigation.navigate).toHaveBeenCalledWith(
       Routes.PERPS.FUNDING_TRANSACTION,