runcommand: replace hard coded /dev/shm with log_dir, add a runcommand configuration menu item#3557
runcommand: replace hard coded /dev/shm with log_dir, add a runcommand configuration menu item#3557twojstaryzdomu wants to merge 3 commits intoRetroPie:masterfrom
Conversation
…use /tmp as fallback This is to allow another directory for runcommand.sh outputs for cases when output are worth preserving (i.e. crash). Also, /dev/shm may not be accessible on all environments, for user discretionary reasons. When /dev/shm doesn't exist or isn't writable, Fall back to /tmp.
twojstaryzdomu
force-pushed
the
runcommand_output_dir
branch
from
f269dd5 to
de233e8
Compare
|
I'm not sure it needs to be in the GUI. But if I will add that I would prefer to do it in my previous PR rather than yours based on mine. |
|
I would consider the PR on its sole merit, not the fact of not being its author. What is the case for the other runcommand.sh options in the GUI that have their configuration file equivalent? I considered the case of users who need persistency for their logs across crashes and the ability to update it quickly. |
|
Well I'd already started on the changes. I don't think it needs to be multiple commits and I'd like to implement it in the way I want. If that's ok. |
Absolutely, you're entitled to prefer your own commits, even if they could be done better. Had your PR been up to scratch, I wouldn't have submitted mine. The inconsistencies with the other configuration items being in the GUI is a fact. It's up to you to decide but with my multiple PRs closed without merging, I just wonder if it's a pet project thing where maintainers settle for worse regardless of the actual merit. Is there a systemic problem with external contributions? |
2 participants
This PR extends #3556 with a retropie menu configuration entry for the log/scratch area
log_dirvariable and replaces the remaining hard-coded/dev/shmvalues with thelog_dirvariable.