Release v0.2.8.4

Author: RoBro92

README.md

@@ -21,13 +21,13 @@ It outputs system details, update status, and network configuration, then writes
 1. Download the latest `.deb` from the [Releases](https://github.com/RoBro92/nodeinfo/releases) page and install it on your Proxmox host:
 
 ```bash 
-   wget https://github.com/RoBro92/nodeinfo/releases/latest/download/nodeinfo_v0.2.8.3.deb
+   wget https://github.com/RoBro92/nodeinfo/releases/latest/download/nodeinfo_v0.2.8.4.deb
    ```
 
 2. Install the package:
 
 ```bash
-sudo dpkg -i nodeinfo_v0.2.8.3.deb
+sudo dpkg -i nodeinfo_v0.2.8.4.deb
 ```
 
 3. Once installed you can run:

nodeinfo/debian/control

@@ -1,5 +1,5 @@
 Package: nodeinfo
-Version: 0.2.8.3
+Version: 0.2.8.4
 Section: admin
 Priority: optional
 Architecture: all

nodeinfo/usr/local/bin/nodeinfo

@@ -7,7 +7,7 @@ import os
 import re
 import requests
 
-VERSION = "0.2.8.3"
+VERSION = "0.2.8.4"
 GITHUB_REPO = "RoBro92/nodeinfo"
 
 if "--version" in sys.argv or "-v" in sys.argv:
@@ -256,7 +256,6 @@ def update_notes(vmid, vmtype, markdown):
             with open(config_path, "r") as f:
                 lines = f.readlines()
 
-            # Find nodeinfo block boundaries
             start_idx = end_idx = None
             for i, line in enumerate(lines):
                 if line.strip() == "# === nodeinfo start ===":
@@ -266,78 +265,78 @@ def update_notes(vmid, vmtype, markdown):
                     break
 
             if start_idx is not None and end_idx is not None:
+                # Nodeinfo block exists
+
                 # Extract current nodeinfo block lines
-                nodeinfo_block = lines[start_idx+1:end_idx]
+                nodeinfo_block = lines[start_idx + 1:end_idx]
 
-                # Find user notes header line index in nodeinfo block
-                user_notes_header = "📝 **User Notes**"
+                # Find the user notes header line index inside nodeinfo block
+                user_notes_header = "# 📝 **User Notes**"
                 user_notes_start_idx = None
                 for i, line in enumerate(nodeinfo_block):
-                    # Strip '#' and whitespace for matching header
-                    if line.lstrip("# ").strip() == user_notes_header:
+                    if line.strip() == user_notes_header:
                         user_notes_start_idx = i
                         break
 
                 if user_notes_start_idx is not None:
-                    # Preserve all user notes lines from header to end of nodeinfo block
-                    preserved_user_notes = nodeinfo_block[user_notes_start_idx:]
-                    # Notes before user notes section (autogenerated)
-                    autogenerated_notes = nodeinfo_block[:user_notes_start_idx]
+                    # Split autogenerated and user notes parts
+                    autogenerated_lines = nodeinfo_block[:user_notes_start_idx]
+                    user_notes_lines = nodeinfo_block[user_notes_start_idx:]
                 else:
-                    # No user notes section: all is autogenerated
-                    preserved_user_notes = []
-                    autogenerated_notes = nodeinfo_block
-
-                # Confirm overwrite if notes exist (you can keep your existing confirmation logic here)
-
-                # Prepare new autogenerated notes lines (with '# ' prefix)
+                    # No user notes section: treat all as autogenerated, user notes empty
+                    autogenerated_lines = nodeinfo_block
+                    user_notes_lines = [
+                        "# 📝 **User Notes**\n",
+                        "#\n",
+                        "# *(You can safely add your notes here. This section will be preserved when nodeinfo updates.)*\n"
+                    ]
+
+                # Prompt user to confirm overwrite
+                confirm = input("⚠️ A previous nodeinfo block was found. Overwrite autogenerated section? (y/N): ").strip().lower()
+                if confirm != "y":
+                    print("❌ Update cancelled.")
+                    return False  # Don't update, no message printed below
+
+                # Prepare new autogenerated notes lines with '# ' prefix
                 new_autogen_notes = [f"# {line}\n" for line in markdown.splitlines()]
-                # Remove user notes header and below from new_autogen_notes if present
-                # (to avoid duplication)
-                if user_notes_header in markdown:
-                    idx = markdown.splitlines().index(user_notes_header)
-                    new_autogen_notes = [f"# {line}\n" for line in markdown.splitlines()[:idx]]
-
-                # Compose final new notes block:
-                new_nodeinfo_block = new_autogen_notes
-                if preserved_user_notes:
-                    new_nodeinfo_block.extend(preserved_user_notes)
-                else:
-                    # Add default user notes header and placeholder if none preserved
-                    new_nodeinfo_block.append(f"# {user_notes_header}\n")
-                    new_nodeinfo_block.append("#\n")
-                    new_nodeinfo_block.append("# *(You can safely add your notes here. This section will be preserved when nodeinfo updates.)*\n")
+
+                # Compose final nodeinfo block: new autogenerated + preserved user notes
+                new_nodeinfo_block = new_autogen_notes + user_notes_lines
 
                 # Wrap with start and end markers
                 final_notes = ["# === nodeinfo start ===\n"] + new_nodeinfo_block + ["# === nodeinfo end ===\n"]
 
-                # Remove all previous note lines (lines starting with '#') between start_idx and end_idx
-                # And insert the final_notes
-                new_lines = lines[:start_idx] + final_notes + lines[end_idx+1:]
+                # Replace old block with new block
+                new_lines = lines[:start_idx] + final_notes + lines[end_idx + 1:]
 
                 with open(config_path, "w") as f:
                     f.writelines(new_lines)
 
                 print(f"✅ Notes written to {config_path}")
                 return True
+
             else:
-                # No nodeinfo block found, just append it at the end of the config file
+                # No nodeinfo block found, append new block + default user notes
                 with open(config_path, "a") as f:
-                    f.write("\n# === nodeinfo start ===\n")
+                    f.write("# === nodeinfo start ===\n")
                     for line in markdown.splitlines():
                         f.write(f"# {line}\n")
+                    f.write("# 📝 **User Notes**\n")
+                    f.write("#\n")
+                    f.write("# *(You can safely add your notes here. This section will be preserved when nodeinfo updates.)*\n")
                     f.write("# === nodeinfo end ===\n")
                 print(f"✅ Nodeinfo notes appended to {config_path}")
                 return True
+
         except Exception as e:
             print(f"❌ Failed to write LXC notes: {e}")
             return False
+
     else:
-        # QEMU notes handling (overwrite)
+        # QEMU VM notes overwrite completely
         subprocess.run(["qm", "set", vmid, "--notes", markdown])
         return True
 
-
 def do_self_update():
 
     try: