Skip to content

Commit ba6dfaa

Browse files
KlattGflovogt
KlattG
authored and
flovogt
committed
ref: Use static sap/ui/core/UIComponent.getRouterFor instead of casting
1 parent 86a7f7c commit ba6dfaa

File tree

24 files changed

+55
-55
lines changed

24 files changed

+55
-55
lines changed

‎steps/09/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ Finally we call the `createContent` hook method of the component. This method cr
4141

4242
```ts
4343
import Control from "sap/ui/core/Control";
44-
import UIComponent from "sap/ui/core/UIComponent";
4544
import XMLView from "sap/ui/core/mvc/XMLView";
4645
import JSONModel from "sap/ui/model/json/JSONModel";
4746
import ResourceModel from "sap/ui/model/resource/ResourceModel";
47+
import UIComponent from "sap/ui/core/UIComponent";
4848

4949
/**
5050
* @namespace ui5.walkthrough

‎steps/10/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,4 +250,4 @@ We can now delete our `index.ts` file, because our component is now initiated di
250250

251251
[API Reference: `sap.ui.core.ComponentSupport`](https://sdk.openui5.org/api/sap.ui.core.ComponentSupport)
252252

253-
[Make Your App CSP Compliant](https://sdk.openui5.org/topic/1f81a093a9f3433983dcb2ebe11cd4cd.html "CSP stands for Content Security Policy and is a security standard to prevent cross-site scripting or other code injection attacks.")
253+
[Make Your App CSP Compliant](https://sdk.openui5.org/topic/1f81a093a9f3433983dcb2ebe11cd4cd.html "CSP stands for Content Security Policy and is a security standard to prevent cross-site scripting or other code injection attacks.")

‎steps/30/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ import { SearchField$SearchEvent } from "sap/m/SearchField";
233233
import Filter from "sap/ui/model/Filter";
234234
import FilterOperator from "sap/ui/model/FilterOperator";
235235
import ListBinding from "sap/ui/model/ListBinding";
236-
import Component from "../Component";
236+
import UIComponent from "sap/ui/core/UIComponent";
237237

238238
/**
239239
* @namespace ui5.walkthrough.controller
@@ -243,7 +243,7 @@ export default class App extends Controller {
243243
…
244244

245245
onPress(): void {
246-
const router = (this.getOwnerComponent() as Component).getRouter();
246+
const router = UIComponent.getRouterFor(this);
247247
router.navTo("detail");
248248
}
249249
};

‎steps/30/webapp/controller/InvoiceList.controller.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { SearchField$SearchEvent } from "sap/m/SearchField";
44
import Filter from "sap/ui/model/Filter";
55
import FilterOperator from "sap/ui/model/FilterOperator";
66
import ListBinding from "sap/ui/model/ListBinding";
7-
import Component from "../Component";
7+
import UIComponent from "sap/ui/core/UIComponent";
88

99
/**
1010
* @namespace ui5.walkthrough.controller
@@ -32,7 +32,7 @@ export default class App extends Controller {
3232
}
3333

3434
onPress(): void {
35-
const router = (this.getOwnerComponent() as Component).getRouter();
35+
const router = UIComponent.getRouterFor(this);
3636
router.navTo("detail");
3737
}
3838
};

‎steps/31/README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ import { SearchField$SearchEvent } from "sap/m/SearchField";
9292
import Filter from "sap/ui/model/Filter";
9393
import FilterOperator from "sap/ui/model/FilterOperator";
9494
import ListBinding from "sap/ui/model/ListBinding";
95-
import Component from "../Component";
9695
import Event from "sap/ui/base/Event";
9796
import ObjectListItem from "sap/m/ObjectListItem";
97+
import UIComponent from "sap/ui/core/UIComponent";
9898

9999
/**
100100
* @namespace ui5.walkthrough.controller
@@ -106,7 +106,7 @@ export default class App extends Controller {
106106

107107
onPress(event: Event): void {
108108
const item = event.getSource() as ObjectListItem;
109-
const router = (this.getOwnerComponent() as Component).getRouter();
109+
const router = UIComponent.getRouterFor(this);
110110
router.navTo("detail", {
111111
invoicePath: window.encodeURIComponent(item.getBindingContext("invoice").getPath().substr(1))
112112
});
@@ -131,7 +131,7 @@ The `bindElement` function is creating a binding context for a OpenUI5 control a
131131

132132
```ts
133133
import Controller from "sap/ui/core/mvc/Controller";
134-
import Component from "../Component";
134+
import UIComponent from "sap/ui/core/UIComponent";
135135
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
136136

137137
/**
@@ -140,7 +140,7 @@ import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
140140
export default class Detail extends Controller {
141141

142142
onInit(): void {
143-
const router = (this.getOwnerComponent() as Component).getRouter();
143+
const router = UIComponent.getRouterFor(this);
144144
router.getRoute("detail").attachPatternMatched(this.onObjectMatched, this);
145145
}
146146

‎steps/31/webapp/controller/Detail.controller.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import Controller from "sap/ui/core/mvc/Controller";
2-
import Component from "../Component";
32
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
3+
import UIComponent from "sap/ui/core/UIComponent";
44

55
/**
66
* @namespace ui5.walkthrough.controller
77
*/
88
export default class Detail extends Controller {
99

1010
onInit(): void {
11-
const router = (this.getOwnerComponent() as Component).getRouter();
11+
const router = UIComponent.getRouterFor(this);
1212
router.getRoute("detail").attachPatternMatched(this.onObjectMatched, this);
1313
}
1414

‎steps/31/webapp/controller/InvoiceList.controller.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { SearchField$SearchEvent } from "sap/m/SearchField";
44
import Filter from "sap/ui/model/Filter";
55
import FilterOperator from "sap/ui/model/FilterOperator";
66
import ListBinding from "sap/ui/model/ListBinding";
7-
import Component from "../Component";
7+
import UIComponent from "sap/ui/core/UIComponent";
88
import Event from "sap/ui/base/Event";
99
import ObjectListItem from "sap/m/ObjectListItem";
1010

@@ -35,7 +35,7 @@ export default class App extends Controller {
3535

3636
onPress(event: Event): void {
3737
const item = event.getSource() as ObjectListItem;
38-
const router = (this.getOwnerComponent() as Component).getRouter();
38+
const router = UIComponent.getRouterFor(this);
3939
router.navTo("detail", {
4040
invoicePath: window.encodeURIComponent(item.getBindingContext("invoice").getPath().substr(1))
4141
});

‎steps/32/README.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ If no navigation has happened before, we get a reference to the router and use t
3434

3535
```ts
3636
import Controller from "sap/ui/core/mvc/Controller";
37-
import Component from "../Component";
3837
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
3938
import History from "sap/ui/core/routing/History";
39+
import UIComponent from "sap/ui/core/UIComponent";
4040

4141
/**
4242
* @namespace ui5.walkthrough.controller
4343
*/
4444
export default class Detail extends Controller {
4545

4646
onInit(): void {
47-
const router = (this.getOwnerComponent() as Component).getRouter();
47+
const router = UIComponent.getRouterFor(this);
4848
router.getRoute("detail").attachPatternMatched(this.onObjectMatched, this);
4949
}
5050

@@ -62,7 +62,7 @@ export default class Detail extends Controller {
6262
if (previousHash !== undefined) {
6363
window.history.go(-1);
6464
} else {
65-
const router = (this.getOwnerComponent() as Component).getRouter();
65+
const router = UIComponent.getRouterFor(this);
6666
router.navTo("overview", {}, true);
6767
}
6868
}

‎steps/32/webapp/controller/Detail.controller.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import Controller from "sap/ui/core/mvc/Controller";
2-
import Component from "../Component";
32
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
43
import History from "sap/ui/core/routing/History";
4+
import UIComponent from "sap/ui/core/UIComponent";
55

66
/**
77
* @namespace ui5.walkthrough.controller
88
*/
99
export default class Detail extends Controller {
1010

1111
onInit(): void {
12-
const router = (this.getOwnerComponent() as Component).getRouter();
12+
const router = UIComponent.getRouterFor(this);
1313
router.getRoute("detail").attachPatternMatched(this.onObjectMatched, this);
1414
}
1515

@@ -27,7 +27,7 @@ export default class Detail extends Controller {
2727
if (previousHash !== undefined) {
2828
window.history.go(-1);
2929
} else {
30-
const router = (this.getOwnerComponent() as Component).getRouter();
30+
const router = UIComponent.getRouterFor(this);
3131
router.navTo("overview", {}, true);
3232
}
3333
}

‎steps/32/webapp/controller/InvoiceList.controller.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { SearchField$SearchEvent } from "sap/m/SearchField";
44
import Filter from "sap/ui/model/Filter";
55
import FilterOperator from "sap/ui/model/FilterOperator";
66
import ListBinding from "sap/ui/model/ListBinding";
7-
import Component from "../Component";
87
import Event from "sap/ui/base/Event";
98
import ObjectListItem from "sap/m/ObjectListItem";
9+
import UIComponent from "sap/ui/core/UIComponent";
1010

1111
/**
1212
* @namespace ui5.walkthrough.controller
@@ -35,7 +35,7 @@ export default class App extends Controller {
3535

3636
onPress(event: Event): void {
3737
const item = event.getSource() as ObjectListItem;
38-
const router = (this.getOwnerComponent() as Component).getRouter();
38+
const router = UIComponent.getRouterFor(this);
3939
router.navTo("detail", {
4040
invoicePath: window.encodeURIComponent(item.getBindingContext("invoice").getPath().substr(1))
4141
});

0 commit comments

Comments
 (0)