-
Notifications
You must be signed in to change notification settings - Fork 0
Description
If I were to follow the existing pattern for the accelerometer, I'd add error flags to the error_flags_t typedef:
| typedef enum error_flags |
However, that is a 32-bit unsigned int, and already has 32 flags.
It would work to refactor it into two sets of flags, but that would change the SBD message definition, since accumulated errors are directly copied into the SBD52 message:
| memcpy (&sbd_message.error_bits, &error_bits, sizeof(uint32_t)); |
For backwards compatibility in data analysis, I'd probably leave the existing flags as-is and create a second set of flags, even though the code would be cleaner if the flags were split up logically (e.g. GNSS, everything else).
Before making a change like this, I need to check with Jim about whether adding an additional field to a message requires bumping the message type, or if they have some other migration procedure.