Setting RTC doesn't work in December

[lauralindzey]

In my testing today, the firmware did start out setting the RTC correctly.

More recently, I've been seeing this error consistently:

01/01/70 00:00:09: RTC failed to service request 2, returning code -4.

Sometimes it is truncated: (I think the logger doesn't always flush everything when the microswift is restarting itself)
01/01/70 00:00:201/01/70 00:00:00:
01/01/70 00:00:28: RTC?01/01/70 00:00:00:
01/01/70 00:00:28: RTC failed ?01/01/70 00:00:00:
01/01/70 00:00:22: RTC failed to01/01/70 00:00:00:
01/01/70 00:00:28: RTC failed to service req?01/01/70 00:00:00:

On restart, this continued to be an issue.

[lauralindzey]

I've reverted back to no_despiking

• request 2 is SET_TIME
• code -4 is uSWIFT_PARAMETERS_INVALID

Using the debugger ... setting a breakpoint in _ext_rtc_set_date_time

It looks like there's a bug somewhere in the conversions?
date_time_as_dec has all fields set appropriately.
However, input_date_time has tm_mon = 0xFF, which triggers the error.

Here are the variables, with the program paused at ln 359 (return uSWIFT_PARAMETERS_INVALID;)

[lauralindzey]

Looks like this is due to a typo or off-by-one error that exists in all versions of the code:

microSWIFT_V2.2_Firmware/microSWIFT_V2.2/Core/Components/Src/ext_rtc_server.c

Lines 248 to 250 in a7164db

	struct_ptr->tm_mon = (struct_ptr->tm_mon > 11) ?
	BCD_ERROR : DEC_TO_BCD(struct_ptr->tm_mon)
	;

It looks like this line hasn't been changed since August 2024.
https://github.com/SASlabgroup/microSWIFT_V2.2_Firmware/blame/a7164db695dc3e8ae3c389337ea58123ba1c8632/microSWIFT_V2.2/Core/Components/Src/ext_rtc_server.c#L248

So ... either the microSWIFTs never worked in December, or somewhere else in the code months went from being encoded as 0-11 to 1-12.

[lauralindzey]

A quick look at the git commit history suggests that development was happening in Dec '24, so something else changed since then.

@prbush -- tagging you in on this since you may remember relevant changes off the top of your head. Did something change in the firmwware since last December that affects how months are represented here?