[CodeQuality] improvements as per SQ suggestions

Author: samatstariongroup

ECoreNetto.Reporting/Generators/ModelInspector.cs

@@ -391,6 +391,9 @@ public string AnalyzeDocumentation(EPackage package, bool recursive = false)
         /// <param name="package">
         /// The <see cref="EPackage"/> which needs to be inspected
         /// </param>
+        /// <param name="sb">
+        /// The <see cref="StringBuilder"/>> to which the analysis results are appended
+        /// </param>
         /// <param name="recursive">
         /// A value indicating whether the sub <see cref="EPackage"/>s need to be Analyzed as well
         /// </param>
@@ -406,12 +409,10 @@ private void AnalyzeDocumentation(EPackage package, StringBuilder sb, bool recur
                     sb.AppendLine($"{package.Name}.{eClass.Name}");
                 }
 
-                foreach (var eStructuralFeature in eClass.EStructuralFeaturesOrderByName)
+                foreach (var eStructuralFeature in eClass.EStructuralFeaturesOrderByName
+                             .Where(f => string.IsNullOrEmpty(f.QueryRawDocumentation())))
                 {
-                    if (string.IsNullOrEmpty(eStructuralFeature.QueryRawDocumentation()))
-                    {
-                        sb.AppendLine($"{package.Name}.{eClass.Name}:{eStructuralFeature.Name}");
-                    }
+                    sb.AppendLine($"{package.Name}.{eClass.Name}:{eStructuralFeature.Name}");
                 }
             }
 

ECoreNetto.Tools/Services/VersionChecker.cs

@@ -83,9 +83,9 @@ public async Task<GitHubRelease> QueryLatestReleaseAsync()
                     return release;
                 }
             }
-            catch (TaskCanceledException)
+            catch (TaskCanceledException taskCanceledException)
             {
-                this.logger.LogWarning("Contacting the GitGub API at {Url} timed out", requestUrl);
+                this.logger.LogWarning(taskCanceledException, "Contacting the GitGub API at {Url} timed out", requestUrl);
             }
             catch (Exception ex)
             {

ECoreNetto/ModelElement/EObject.cs

@@ -26,7 +26,7 @@ namespace ECoreNetto
     using System.Xml;
 
     using Microsoft.Extensions.Logging;
-    
+
     /// <summary>
     /// An <see cref="EObject"/> is the base of all modeled objects. All the method names start with "e" to distinguish the EMF methods from the client methods.
     /// It provides support for the behaviors and features common to all modeled objects.
@@ -89,7 +89,7 @@ public EClass EClass()
         {
             throw new NotImplementedException();
         }
-        
+
         /// <summary>
         /// Gets the containing object, or null.
         /// </summary>

ECoreNetto/ModelElement/NamedElement/EPackage.cs

@@ -209,7 +209,9 @@ protected override string BuildIdentifier()
                 superPackage = superPackage.ESuperPackage;
             }
 
-            packageHierarchy[packageHierarchy.Count - 1] = $"{packageHierarchy.Last()}.ecore#/";
+            packageHierarchy[packageHierarchy.Count - 1] = $"{packageHierarchy[packageHierarchy.Count - 1]}.ecore#/";
+
+
             packageHierarchy.Reverse();
 
             return string.Join("/", packageHierarchy);

ECoreNetto/ModelElement/NamedElement/ETypedElement.cs

@@ -133,7 +133,8 @@ internal override void SetProperties()
 
             if (this.Attributes.TryGetValue("eType", out output))
             {
-                var typeName = output.Split(' ').Last();
+                var parts = output.Split(' ');
+                var typeName = parts[parts.Length - 1];
 
                 this.EType = (EClassifier)this.EResource.GetEObject(typeName);
             }