Make get_error_info optional

Author: SamRemis

packages/smithy-core/src/smithy_core/aio/client.py

@@ -6,7 +6,7 @@
 from collections.abc import Awaitable, Callable, Sequence
 from copy import copy
 from dataclasses import dataclass, field, replace
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, cast
 
 from .. import URI
 from ..auth import AuthParams
@@ -32,6 +32,7 @@
     ClientProtocol,
     ClientTransport,
     EndpointResolver,
+    ErrorClassifyingTransport,
     Request,
     Response,
 )
@@ -468,11 +469,15 @@ async def _handle_attempt[I: SerializeableShape, O: DeserializeableShape](
                         request=request_context.transport_request
                     )
             except Exception as e:
-                error_info = self.transport.get_error_info(e)
-                if error_info.is_timeout_error:
-                    raise ClientTimeoutError(
-                        message=f"Client timeout occurred: {e}"
-                    ) from e
+                if hasattr(self.transport, "get_error_info"):
+                    classifying_transport = cast(
+                        ErrorClassifyingTransport[TRequest, TResponse], self.transport
+                    )
+                    error_info = classifying_transport.get_error_info(e)
+                    if error_info.is_timeout_error:
+                        raise ClientTimeoutError(
+                            message=f"Client timeout occurred: {e}"
+                        ) from e
                 raise
 
             _LOGGER.debug("Received response: %s", transport_response)

packages/smithy-core/src/smithy_core/aio/interfaces/__init__.py

@@ -96,10 +96,20 @@ async def resolve_endpoint(self, params: EndpointResolverParams[Any]) -> Endpoin
 
 
 class ClientTransport[I: Request, O: Response](Protocol):
-    """Protocol-agnostic representation of a client transport (e.g. an HTTP client).
+    """Protocol-agnostic representation of a client transport (e.g. an HTTP client)."""
 
-    Transport implementations must define the get_error_info method to determine which
-    exceptions represent timeout conditions for that transport.
+    async def send(self, request: I) -> O:
+        """Send a request over the transport and receive the response."""
+        ...
+
+
+class ErrorClassifyingTransport[I: Request, O: Response](
+    ClientTransport[I, O], Protocol
+):
+    """A client transport that can classify errors for retry and timeout detection.
+
+    Transport implementations should implement this protocol if they can determine
+    which exceptions represent timeout conditions or other classifiable error types.
     """
 
     def get_error_info(self, exception: Exception, **kwargs: Any) -> ClientErrorInfo:
@@ -110,14 +120,10 @@ def get_error_info(self, exception: Exception, **kwargs: Any) -> ClientErrorInfo
             **kwargs: Additional context for analysis
 
         Returns:
-            ClientErrorInfo with timeout information.
+            ClientErrorInfo with error classification details.
         """
         ...
 
-    async def send(self, request: I) -> O:
-        """Send a request over the transport and receive the response."""
-        ...
-
 
 class ClientProtocol[I: Request, O: Response](Protocol):
     """A protocol used by a client to communicate with a server."""

packages/smithy-http/tests/unit/aio/test_protocols.py

@@ -139,7 +139,6 @@ def test_http_protocol_joins_uris(
     assert actual == expected
 
 
-@pytest.mark.asyncio
 async def test_http_408_creates_timeout_error() -> None:
     protocol = Mock(spec=HttpBindingClientProtocol)
     protocol.error_identifier = Mock()