minecraft/protocol: Fix shield blocking tick (#420)

Author: HashimTheArab

minecraft/protocol/item.go

@@ -36,6 +36,8 @@ type ItemStack struct {
 	CanBreak []string
 	// HasNetworkID ...
 	HasNetworkID bool
+	// BlockingTick is the tick at which a shield started blocking. It is only used for shield items.
+	BlockingTick int64
 }
 
 // ItemType represents a consistent combination of network ID and metadata value of an item. It cannot usually

minecraft/protocol/reader.go

@@ -467,8 +467,7 @@ func (r *Reader) ItemInstance(i *ItemInstance) {
 	FuncSliceUint32Length(bufReader, &x.CanBreak, bufReader.StringUTF)
 
 	if x.NetworkID == bufReader.shieldID {
-		var blockingTick int64
-		bufReader.Int64(&blockingTick)
+		bufReader.Int64(&x.BlockingTick)
 	}
 }
 
@@ -517,8 +516,7 @@ func (r *Reader) Item(x *ItemStack) {
 	FuncSliceUint32Length(bufReader, &x.CanBreak, bufReader.StringUTF)
 
 	if x.NetworkID == bufReader.shieldID {
-		var blockingTick int64
-		bufReader.Int64(&blockingTick)
+		bufReader.Int64(&x.BlockingTick)
 	}
 }
 

minecraft/protocol/writer.go

@@ -362,8 +362,7 @@ func (w *Writer) ItemInstance(i *ItemInstance) {
 	FuncSliceUint32Length(bufWriter, &x.CanBreak, bufWriter.StringUTF)
 
 	if x.NetworkID == bufWriter.shieldID {
-		var blockingTick int64
-		bufWriter.Int64(&blockingTick)
+		bufWriter.Int64(&x.BlockingTick)
 	}
 
 	b := buf.Bytes()
@@ -407,8 +406,7 @@ func (w *Writer) Item(x *ItemStack) {
 	FuncSliceUint32Length(bufWriter, &x.CanBreak, bufWriter.StringUTF)
 
 	if x.NetworkID == bufWriter.shieldID {
-		var blockingTick int64
-		bufWriter.Int64(&blockingTick)
+		bufWriter.Int64(&x.BlockingTick)
 	}
 
 	extraData := buf.Bytes()