Commit 3785e28
committed
Fix inverted ChatMix level for SteelSeries Arctis 7/Pro (#475)
The chatmix level calculation had game and chat directions swapped:
max game volume produced level > 64 (indicating chat), and vice versa.
This bug originated in the old C implementation (steelseries_arctis_7.c)
and was carried over verbatim during the C++ rewrite (#443). It went
unnoticed because the old code returned a plain int with no defined
semantics for direction, users just saw a changing number. The bug
became observable once ChatmixResult defined < 64 as game and > 64 as
chat.1 parent b627b4b commit 3785e28
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| 158 | + | |
| 159 | + | |
158 | 160 | | |
159 | 161 | | |
160 | 162 | | |
161 | 163 | | |
162 | | - | |
| 164 | + | |
163 | 165 | | |
164 | | - | |
| 166 | + | |
165 | 167 | | |
166 | 168 | | |
167 | 169 | | |
| |||
0 commit comments