more problems with math in plugins (Trac #1173) #1209
Description
while testing a pull request downloaded from the jenkins build thereof, the old
unsupported operand type(s) for *:'NoneType' and 'float'
reared its head again. Other plugins had no problems. Further investigation shows that the exact same function generated from a 4.2 "create model" works while the failing function was created in 4.1.2? However, after editing so that code wise they look identical to me the "older" version continues to fail on the math while the new one does not. I attach the two files.
Is this due to sasmodels infrastructure running these two identical codes differently with one path being wrong? i.e. having a bug not present in the way the files identified as new don't?
Our release notes say we support old style models am listing this as critical to 4.2 release. At the very least we need to correct the release notes if we cannot resolve this issue.
Migrated from http://trac.sasview.org/ticket/1173
{
"status": "closed",
"changetime": "2018-09-25T23:15:49",
"_ts": "2018-09-25 23:15:49.928933+00:00",
"description": "while testing a pull request downloaded from the jenkins build thereof, the old \n{{{\nunsupported operand type(s) for *:'NoneType' and 'float'\n}}}\nreared its head again. Other plugins had no problems. Further investigation shows that the exact same function generated from a 4.2 \"create model\" works while the failing function was created in 4.1.2? However, after editing so that code wise they look identical to me the \"older\" version continues to fail on the math while the new one does not. I attach the two files.\n\nIs this due to sasmodels infrastructure running these two identical codes differently with one path being wrong? i.e. having a bug not present in the way the files identified as new don't?\n\nOur release notes say we support old style models am listing this as critical to 4.2 release. At the very least we need to correct the release notes if we cannot resolve this issue.",
"reporter": "butler",
"cc": "",
"resolution": "fixed",
"workpackage": "McSAS Integration Project",
"time": "2018-09-09T19:17:21",
"component": "SasView",
"summary": "more problems with math in plugins",
"priority": "critical",
"keywords": "",
"milestone": "SasView 4.2.0",
"owner": "pkienzle",
"type": "defect"
}